Remove unused rootTag

Summary: `rootTag` is a lie, it's passed around but never actually used. IIRC `findInstanceByNativeTag` needed it but seems like not anymore. Reviewed By: spicyj Differential Revision: D3382144 fbshipit-source-id: eb96870a3848333e66bf045e78e95c7763812cc4
yudong22 · Jun 8, 2016 · 30e9c40 · 30e9c40
1 parent f26c908
commit 30e9c40
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 6 deletions.
diff --git a/Libraries/Inspector/Inspector.js b/Libraries/Inspector/Inspector.js
@@ -32,7 +32,6 @@ if (window.__REACT_DEVTOOLS_GLOBAL_HOOK__) {
 class Inspector extends React.Component {
   props: {
     inspectedViewTag: ?number,
-    rootTag: ?number,
     onRequestRerenderApp: (callback: (tag: ?number) => void) => void
   };
 
@@ -198,7 +197,6 @@ class Inspector extends React.Component {
       <View style={styles.container} pointerEvents="box-none">
         {this.state.inspecting &&
           <InspectorOverlay
-            rootTag={this.props.rootTag}
             inspected={this.state.inspected}
             inspectedViewTag={this.state.inspectedViewTag}
             onTouchInstance={this.onTouchInstance.bind(this)}

diff --git a/Libraries/Inspector/InspectorOverlay.js b/Libraries/Inspector/InspectorOverlay.js
@@ -41,7 +41,7 @@ var InspectorOverlay = React.createClass({
       this.props.inspectedViewTag,
       [locationX, locationY],
       (nativeViewTag, left, top, width, height) => {
-        var instance = InspectorUtils.findInstanceByNativeTag(this.props.rootTag, nativeViewTag);
+        var instance = InspectorUtils.findInstanceByNativeTag(nativeViewTag);
         if (!instance) {
           return;
         }

diff --git a/Libraries/Inspector/InspectorUtils.js b/Libraries/Inspector/InspectorUtils.js
@@ -19,7 +19,7 @@ function traverseOwnerTreeUp(hierarchy, instance) {
   }
 }
 
-function findInstanceByNativeTag(rootTag, nativeTag) {
+function findInstanceByNativeTag(nativeTag) {
   return ReactNativeComponentTree.getInstanceFromNode(nativeTag);
 }
 

diff --git a/Libraries/ReactIOS/AppContainer.js b/Libraries/ReactIOS/AppContainer.js
@@ -33,7 +33,6 @@ var AppContainer = React.createClass({
     var inspector = !__DEV__ || this.state.inspector
       ? null
       : <Inspector
-          rootTag={this.props.rootTag}
           inspectedViewTag={ReactNative.findNodeHandle(this.refs.main)}
           onRequestRerenderApp={(updateInspectedViewTag) => {
             this.setState(

diff --git a/Libraries/ReactIOS/renderApplication.ios.js b/Libraries/ReactIOS/renderApplication.ios.js
@@ -28,7 +28,7 @@ function renderApplication<P>(
     'Expect to have a valid rootTag, instead got ', rootTag
   );
   ReactNative.render(
-    <AppContainer rootTag={rootTag}>
+    <AppContainer>
       <RootComponent
         {...initialProps}
         rootTag={rootTag}
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ function traverseOwnerTreeUp(hierarchy, instance) { @@
       }
     }
-    function findInstanceByNativeTag(rootTag, nativeTag) {
+    function findInstanceByNativeTag(nativeTag) {
       return ReactNativeComponentTree.getInstanceFromNode(nativeTag);
     }
@@ Expand Down @@