Skip to content

Commit

Permalink
Remove redundant profile events
Browse files Browse the repository at this point in the history
Summary:
public

Remove some of the manual markers from the bridge since they will already be added dinamically.

Reviewed By: jspahrsummers

Differential Revision: D2761748

fb-gh-sync-id: 0c726373f9105258feb8230d30453559ed1e6a65
  • Loading branch information
tadeuzagallo authored and facebook-github-bot-4 committed Dec 16, 2015
1 parent f567302 commit f8c125c
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions React/Base/RCTBatchedBridge.m
Original file line number Diff line number Diff line change
Expand Up @@ -908,8 +908,6 @@ - (BOOL)_handleRequestNumber:(NSUInteger)i
return NO;
}

RCT_PROFILE_BEGIN_EVENT(0, [NSString stringWithFormat:@"[%@ %@]", moduleData.name, method.JSMethodName], nil);

@try {
[method invokeWithBridge:self module:moduleData.instance arguments:params];
}
Expand All @@ -925,13 +923,6 @@ - (BOOL)_handleRequestNumber:(NSUInteger)i
RCTFatal(RCTErrorWithMessage(message));
}

if (RCTProfileIsProfiling()) {
NSMutableDictionary *args = [method.profileArgs mutableCopy];
args[@"method"] = method.JSMethodName;
args[@"args"] = RCTJSONStringify(RCTNullIfNil(params), NULL);
RCT_PROFILE_END_EVENT(0, @"objc_call", args);
}

return YES;
}

Expand All @@ -948,9 +939,7 @@ - (void)_jsThreadUpdate:(CADisplayLink *)displayLink

[self dispatchBlock:^{
RCTProfileEndFlowEvent();
RCT_PROFILE_BEGIN_EVENT(0, [NSString stringWithFormat:@"[%@ didUpdateFrame:%f]", observer, displayLink.timestamp], nil);
[observer didUpdateFrame:frameUpdate];
RCT_PROFILE_END_EVENT(0, @"objc_call,fps", nil);
} queue:moduleData.methodQueue];
}
}
Expand Down

0 comments on commit f8c125c

Please sign in to comment.