Small fixes

yueh-github · Jun 8, 2022 · 4b93cac · 4b93cac
1 parent a839587
commit 4b93cac
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/contracts/lib/AmountDeriver.sol b/contracts/lib/AmountDeriver.sol
@@ -17,15 +17,15 @@ import "./ConsiderationConstants.sol";
  */
 contract AmountDeriver is AmountDerivationErrors {
     /**
-     * @dev Internal pure function to derive the current amount of a given item
+     * @dev Internal view function to derive the current amount of a given item
      *      based on the current price, the starting price, and the ending
      *      price. If the start and end prices differ, the current price will be
      *      interpolated on a linear basis.
      *
      * @param startAmount The starting amount of the item.
      * @param endAmount   The ending amount of the item.
-     * @param startTime   The starting time of the order
-     * @param endTime     The end time of the order
+     * @param startTime   The starting time of the order.
+     * @param endTime     The end time of the order.
      * @param roundUp     A boolean indicating whether the resultant amount
      *                    should be rounded up or down.
      *
@@ -127,16 +127,16 @@ contract AmountDeriver is AmountDerivationErrors {
     }
 
     /**
-     * @dev Internal pure function to apply a fraction to a consideration
+     * @dev Internal view function to apply a fraction to a consideration
      * or offer item.
      *
      * @param startAmount     The starting amount of the item.
      * @param endAmount       The ending amount of the item.
      * @param numerator       A value indicating the portion of the order that
      *                        should be filled.
      * @param denominator     A value indicating the total size of the order.
-     * @param startTime       The starting time of the order
-     * @param endTime         The end time of the order
+     * @param startTime       The starting time of the order.
+     * @param endTime         The end time of the order.
      * @param roundUp         A boolean indicating whether the resultant
      *                        amount should be rounded up or down.
      *

diff --git a/contracts/lib/OrderCombiner.sol b/contracts/lib/OrderCombiner.sol
@@ -236,7 +236,7 @@ contract OrderCombiner is OrderFulfiller, FulfillmentApplier {
                 // Place the start time for the order on the stack.
                 uint256 startTime = advancedOrder.parameters.startTime;
 
-                // Place the end for the order on the stack.
+                // Place the end time for the order on the stack.
                 uint256 endTime = advancedOrder.parameters.endTime;
 
                 // Retrieve array of offer items for the order in question.

diff --git a/reference/lib/ReferenceAmountDeriver.sol b/reference/lib/ReferenceAmountDeriver.sol
@@ -17,15 +17,15 @@ import { FractionData } from "./ReferenceConsiderationStructs.sol";
  */
 contract ReferenceAmountDeriver is AmountDerivationErrors {
     /**
-     * @dev Internal pure function to derive the current amount of a given item
+     * @dev Internal view function to derive the current amount of a given item
      *      based on the current price, the starting price, and the ending
      *      price. If the start and end prices differ, the current price will be
      *      interpolated on a linear basis.
      *
      * @param startAmount The starting amount of the item.
      * @param endAmount   The ending amount of the item.
-     * @param startTime   The starting time of the order
-     * @param endTime     The end time of the order
+     * @param startTime   The starting time of the order.
+     * @param endTime     The end time of the order.
      * @param roundUp     A boolean indicating whether the resultant amount
      *                    should be rounded up or down.
      *
@@ -108,7 +108,7 @@ contract ReferenceAmountDeriver is AmountDerivationErrors {
     }
 
     /**
-     * @dev Internal pure function to apply a fraction to a consideration
+     * @dev Internal view function to apply a fraction to a consideration
      * or offer item.
      *
      * @param startAmount     The starting amount of the item.