Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about retryIntervalMax and retryTimesMax #184

Closed
stoneshi-yunify opened this issue Sep 23, 2021 · 0 comments · Fixed by #185 or #186
Closed

about retryIntervalMax and retryTimesMax #184

stoneshi-yunify opened this issue Sep 23, 2021 · 0 comments · Fixed by #185 or #186
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@stoneshi-yunify
Copy link
Contributor

What would you like to be added:
the arguments:

	retryIntervalMax = flag.Duration("retry-interval-max", 2*time.Minute, "Maximum retry interval of failed deletion.")
	retryTimesMax    = flag.Int("retry-times-max", 10, "Maximum retry times of failed detach volume.")

retryIntervalMax: is this still needed? as the sidecar already have exponential backoff.

retryTimesMax: 10 is too small as default. 100 may be better. And it should allow to completely disable this limits. such as a value of 0 or -1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants