Change default detach retry limit to 100 & enable unlimit option #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dkeven <[email protected]>
dkeven
force-pushed
the
updateretrylimiter
branch
from
3fbd196 to
8d673c0
Compare
| endpoint = flag.String("endpoint", "unix://tmp/csi.sock", "CSI endpoint") | ||
| maxVolume = flag.Int64("maxvolume", 10, "Maximum number of volumes that controller can publish to the node.") | ||
| nodeId = flag.String("nodeid", "", "If driver cannot get instance ID from /etc/qingcloud/instance-id, we would use this flag.") | ||
| retryIntervalMax = flag.Duration("retry-interval-max", 2*time.Minute, "Maximum retry interval of failed deletion.") |
There was a problem hiding this comment.
should we remove retryIntervalMax? ie. remove the retries and hand over the control to csi sidecar?
There was a problem hiding this comment.
Yes, I think it should be removed, I'll do that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dkeven [email protected]
What type of PR is this?
/kind improvement
What this PR does / why we need it:
Currently, the detaching retry limiter(added in #160) will block any further detaching operation for a specific volume if this volume has more than
--retry-times-max(defaults to 10) failed detaching operations recorded in the limiter.But very often, when the cause of the failing detachments is fixed or self-recovered, the retry times have already exceeded the maxium, and since the retry times are stored in a map and never reset, this leaves the detaching of the volume blocked forever.
This PR:
--retry-times-maxoption to--retry-detach-times-max.--retry-detach-times-maxto0.Which issue(s) this PR fixes:
Fixes #184