Initialize OpacityLayer's matrix to identity (flutter#8467)

Should have flutter/flutter#30586 fixed once the engine rolls.
yunyu · Apr 6, 2019 · 0c2a2c1 · 0c2a2c1
1 parent 7fd4caf
commit 0c2a2c1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/flow/layers/opacity_layer.cc b/flow/layers/opacity_layer.cc
@@ -20,6 +20,13 @@ void OpacityLayer::EnsureSingleChild() {
   }
 
   auto new_child = std::make_shared<flow::TransformLayer>();
+
+  // Be careful: SkMatrix's default constructor doesn't initialize the matrix to
+  // identity. Hence we have to explicitly call SkMatrix::setIdentity.
+  SkMatrix identity;
+  identity.setIdentity();
+
+  new_child->set_transform(identity);
   for (auto& child : layers()) {
     new_child->Add(child);
   }

diff --git a/flow/layers/transform_layer.h b/flow/layers/transform_layer.h
@@ -9,6 +9,8 @@
 
 namespace flow {
 
+// Be careful that SkMatrix's default constructor doesn't initialize the matrix
+// at all. Hence |set_transform| must be called with an initialized SkMatrix.
 class TransformLayer : public ContainerLayer {
  public:
   TransformLayer();