Avoid unnecessary copying of vectors in AccessibilityBridge (flutter#…

…9033)
yunyu · May 21, 2019 · ee5915f · ee5915f
1 parent 74aaf73
commit ee5915f
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm b/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
@@ -198,7 +198,7 @@ - (BOOL)onCustomAccessibilityAction:(FlutterCustomAccessibilityAction*)action {
   args.push_back(action_id >> 16);
   args.push_back(action_id >> 24);
   [self bridge] -> DispatchSemanticsAction([self uid], flutter::SemanticsAction::kCustomAction,
-                                           args);
+                                           std::move(args));
   return YES;
 }
 
@@ -689,14 +689,13 @@ - (BOOL)accessibilityScroll:(UIAccessibilityScrollDirection)direction {
 }
 
 void AccessibilityBridge::DispatchSemanticsAction(int32_t uid, flutter::SemanticsAction action) {
-  std::vector<uint8_t> args;
-  platform_view_->DispatchSemanticsAction(uid, action, args);
+  platform_view_->DispatchSemanticsAction(uid, action, {});
 }
 
 void AccessibilityBridge::DispatchSemanticsAction(int32_t uid,
                                                   flutter::SemanticsAction action,
                                                   std::vector<uint8_t> args) {
-  platform_view_->DispatchSemanticsAction(uid, action, args);
+  platform_view_->DispatchSemanticsAction(uid, action, std::move(args));
 }
 
 SemanticsObject* AccessibilityBridge::GetOrCreateObject(int32_t uid,