deprecating some cmf Additional Amount classes

yuriewalter · Sep 29, 2023 · cc05d30 · cc05d30
1 parent 87012c3
commit cc05d30
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/modules/cmf/src/main/java/org/jpos/cmf/AdditionalAmount.java b/modules/cmf/src/main/java/org/jpos/cmf/AdditionalAmount.java
@@ -23,6 +23,10 @@
 import java.math.BigDecimal;
 import java.util.Objects;
 
+/**
+ * @deprecated Use {@link org.jpos.cmf.CMFAdditionalAmount}
+ */
+@Deprecated
 @SuppressWarnings("WeakerAccess")
 public class AdditionalAmount {
 
@@ -111,16 +115,12 @@ public String serialize() {
 
         long absAmt= getAmount().movePointRight(getCurrencyMinorUnit()).abs().longValue();
 
-        @SuppressWarnings("StringBufferReplaceableByString")
-        StringBuilder sb = new StringBuilder();
-        sb.append(getAccountType());
-        sb.append(getAmountType().toString());
-        sb.append(getCurrencyCode());
-        sb.append(getCurrencyMinorUnit());
-        sb.append(getAmount().compareTo(BigDecimal.ZERO) >= 0 ? "C" : "D");
-        sb.append(StringUtils.leftPad(Long.toString(absAmt), 12, '0'));
-
-        return sb.toString();
+        return  getAccountType() +
+                getAmountType().toString() +
+                getCurrencyCode() +
+                getCurrencyMinorUnit() +
+                (getAmount().compareTo(BigDecimal.ZERO) >= 0 ? "C" : "D") +
+                StringUtils.leftPad(Long.toString(absAmt), 12, '0');
     }
 
     @Override

diff --git a/modules/cmf/src/main/java/org/jpos/cmf/AdditionalAmountsWrapper.java b/modules/cmf/src/main/java/org/jpos/cmf/AdditionalAmountsWrapper.java
@@ -27,7 +27,10 @@
 
 /**
  * Handles additional amounts field content - DE-054
+ *
+ * @deprecated Use {@link org.jpos.iso.AdditionalAmountsWrapper}
  */
+@Deprecated
 public final class AdditionalAmountsWrapper extends LinkedHashSet<AdditionalAmount> {
 
     private static final long serialVersionUID = 2526355280704001241L;

diff --git a/modules/cmf/src/test/java/org/jpos/cmf/AdditionalAmountsWrapperTest.java b/modules/cmf/src/test/java/org/jpos/cmf/AdditionalAmountsWrapperTest.java
@@ -25,7 +25,7 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
-
+@Deprecated
 public final class AdditionalAmountsWrapperTest {
 
     @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,7 @@ @@
     import static org.junit.jupiter.api.Assertions.*;
+    @Deprecated
     public final class AdditionalAmountsWrapperTest {
         @Test
@@ Expand Down @@