ContextReplacementPlugin should remove critical dependency warnings

yut148 · Jul 20, 2016 · 0c78ca7 · 0c78ca7
1 parent 711a382
commit 0c78ca7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/lib/ContextReplacementPlugin.js b/lib/ContextReplacementPlugin.js
@@ -52,6 +52,11 @@ ContextReplacementPlugin.prototype.apply = function(compiler) {
 					result.regExp = newContentRegExp;
 				if(typeof newContentCallback === "function") {
 					newContentCallback(result);
+				} else {
+					result.dependencies.forEach(function(d) {
+						if(d.critical)
+							d.critical = false;
+					});
 				}
 			}
 			return callback(null, result);
@@ -73,6 +78,11 @@ ContextReplacementPlugin.prototype.apply = function(compiler) {
 					if(result.resource !== origResource) {
 						result.resource = path.resolve(origResource, result.resource);
 					}
+				} else {
+					result.dependencies.forEach(function(d) {
+						if(d.critical)
+							d.critical = false;
+					});
 				}
 			}
 			return callback(null, result);

diff --git a/test/configCases/context-replacement/a/warnings.js b/test/configCases/context-replacement/a/warnings.js
diff --git a/test/configCases/context-replacement/b/warnings.js b/test/configCases/context-replacement/b/warnings.js
diff --git a/test/configCases/context-replacement/c/warnings.js b/test/configCases/context-replacement/c/warnings.js