Merge pull request nestjs#1199 from jbpionnier/refactor/void_0_not_ne…

…cessary refactor: remove void 0 not necessary
yuttasakcom · Oct 17, 2018 · a78a31e · a78a31e
2 parents 96b0a19 + bd05652
commit a78a31e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/packages/common/services/logger.service.ts b/packages/common/services/logger.service.ts
@@ -84,7 +84,7 @@ export class Logger implements LoggerService {
     isTimeDiffEnabled?: boolean,
   ) {
     if (Logger.contextEnvironment === NestEnvironment.TEST) {
-      return void 0;
+      return;
     }
     const output =
       message && isObject(message) ? JSON.stringify(message, null, 2) : message;
@@ -110,7 +110,7 @@ export class Logger implements LoggerService {
 
   private static printStackTrace(trace: string) {
     if (this.contextEnvironment === NestEnvironment.TEST || !trace) {
-      return void 0;
+      return;
     }
     process.stdout.write(trace);
     process.stdout.write(`\n`);

diff --git a/packages/core/exceptions/exceptions-handler.ts b/packages/core/exceptions/exceptions-handler.ts
@@ -14,7 +14,7 @@ export class ExceptionsHandler extends BaseExceptionFilter {
 
   public next(exception: Error | HttpException | any, ctx: ArgumentsHost) {
     if (this.invokeCustomFilters(exception, ctx)) {
-      return void 0;
+      return;
     }
     super.catch(exception, ctx);
   }
@@ -29,7 +29,7 @@ export class ExceptionsHandler extends BaseExceptionFilter {
   public invokeCustomFilters(exception, response): boolean {
     if (isEmpty(this.filters)) return false;
 
-    const filter = this.filters.find(({ exceptionMetatypes, func }) => {
+    const filter = this.filters.find(({ exceptionMetatypes }) => {
       const hasMetatype =
         !exceptionMetatypes.length ||
         exceptionMetatypes.some(

diff --git a/packages/core/injector/injector.ts b/packages/core/injector/injector.ts
@@ -133,7 +133,7 @@ export class Injector {
       throw new RuntimeException();
     }
     if (targetMetatype.isResolved) {
-      return void 0;
+      return;
     }
     await this.resolveConstructorParams<T>(
       wrapper,

diff --git a/packages/core/injector/module-ref.ts b/packages/core/injector/module-ref.ts
@@ -45,7 +45,7 @@ export abstract class ModuleRef {
 
   private initFlattenModule() {
     if (this.flattenModuleFixture) {
-      return void 0;
+      return;
     }
     const modules = this.container.getModules();
     const initialValue = {

diff --git a/packages/websockets/exceptions/ws-exceptions-handler.ts b/packages/websockets/exceptions/ws-exceptions-handler.ts
@@ -11,7 +11,7 @@ export class WsExceptionsHandler extends BaseWsExceptionFilter {
   public handle(exception: Error | WsException | any, host: ArgumentsHost) {
     const client = host.switchToWs().getClient();
     if (this.invokeCustomFilters(exception, host) || !client.emit) {
-      return void 0;
+      return;
     }
     super.catch(exception, host);
   }
@@ -26,7 +26,7 @@ export class WsExceptionsHandler extends BaseWsExceptionFilter {
   public invokeCustomFilters(exception, args: ArgumentsHost): boolean {
     if (isEmpty(this.filters)) return false;
 
-    const filter = this.filters.find(({ exceptionMetatypes, func }) => {
+    const filter = this.filters.find(({ exceptionMetatypes }) => {
       const hasMetatype =
         !exceptionMetatypes.length ||
         exceptionMetatypes.some(