Skip to content

Commit

Permalink
[lib/LTO] Add a way to run a custom pipeline
Browse files Browse the repository at this point in the history
Differential Revision:  https://reviews.llvm.org/D24095

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@280830 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
dcci committed Sep 7, 2016
1 parent 6874fa8 commit fab897d
Show file tree
Hide file tree
Showing 5 changed files with 84 additions and 1 deletion.
7 changes: 7 additions & 0 deletions include/llvm/LTO/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ struct Config {
/// Disable entirely the optimizer, including importing for ThinLTO
bool CodeGenOnly = false;

/// If this field is set, the set of passes run in the middle-end optimizer
/// will be the one specified by the string. Only works with the new pass
/// manager as the old one doesn't have this ability.
std::string OptPipeline;

/// Setting this field will replace target triples in input files with this
/// triple.
std::string OverrideTriple;
Expand Down Expand Up @@ -164,6 +169,7 @@ struct Config {
RelocModel(std::move(X.RelocModel)), CodeModel(std::move(X.CodeModel)),
CGOptLevel(std::move(X.CGOptLevel)), OptLevel(std::move(X.OptLevel)),
DisableVerify(std::move(X.DisableVerify)),
OptPipeline(std::move(X.OptPipeline)),
OverrideTriple(std::move(X.OverrideTriple)),
DefaultTriple(std::move(X.DefaultTriple)),
ShouldDiscardValueNames(std::move(X.ShouldDiscardValueNames)),
Expand All @@ -187,6 +193,7 @@ struct Config {
CGOptLevel = std::move(X.CGOptLevel);
OptLevel = std::move(X.OptLevel);
DisableVerify = std::move(X.DisableVerify);
OptPipeline = std::move(X.OptPipeline);
OverrideTriple = std::move(X.OverrideTriple);
DefaultTriple = std::move(X.DefaultTriple);
ShouldDiscardValueNames = std::move(X.ShouldDiscardValueNames);
Expand Down
1 change: 1 addition & 0 deletions lib/LTO/LLVMBuild.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ required_libraries =
MC
ObjCARC
Object
Passes
Scalar
Support
Target
Expand Down
46 changes: 45 additions & 1 deletion lib/LTO/LTOBackend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,18 @@
//===----------------------------------------------------------------------===//

#include "llvm/LTO/LTOBackend.h"
#include "llvm/Analysis/AliasAnalysis.h"
#include "llvm/Analysis/CGSCCPassManager.h"
#include "llvm/Analysis/LoopPassManager.h"
#include "llvm/Analysis/TargetLibraryInfo.h"
#include "llvm/Analysis/TargetTransformInfo.h"
#include "llvm/Bitcode/ReaderWriter.h"
#include "llvm/IR/LegacyPassManager.h"
#include "llvm/IR/PassManager.h"
#include "llvm/IR/Verifier.h"
#include "llvm/LTO/LTO.h"
#include "llvm/MC/SubtargetFeature.h"
#include "llvm/Passes/PassBuilder.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/TargetRegistry.h"
Expand Down Expand Up @@ -115,6 +121,41 @@ createTargetMachine(Config &Conf, StringRef TheTriple,
Conf.CodeModel, Conf.CGOptLevel));
}

static void runNewPMCustomPasses(Module &Mod, TargetMachine *TM,
std::string PipelineDesc,
bool DisableVerify) {
PassBuilder PB(TM);
AAManager AA;
LoopAnalysisManager LAM;
FunctionAnalysisManager FAM;
CGSCCAnalysisManager CGAM;
ModuleAnalysisManager MAM;

// Register the AA manager first so that our version is the one used.
FAM.registerPass([&] { return std::move(AA); });

// Register all the basic analyses with the managers.
PB.registerModuleAnalyses(MAM);
PB.registerCGSCCAnalyses(CGAM);
PB.registerFunctionAnalyses(FAM);
PB.registerLoopAnalyses(LAM);
PB.crossRegisterProxies(LAM, FAM, CGAM, MAM);

ModulePassManager MPM;

// Always verify the input.
MPM.addPass(VerifierPass());

// Now, add all the passes we've been requested to.
if (!PB.parsePassPipeline(MPM, PipelineDesc))
report_fatal_error("unable to parse pass pipeline description: " +
PipelineDesc);

if (!DisableVerify)
MPM.addPass(VerifierPass());
MPM.run(Mod, MAM);
}

static void runOldPMPasses(Config &Conf, Module &Mod, TargetMachine *TM,
bool IsThinLto) {
legacy::PassManager passes;
Expand All @@ -140,7 +181,10 @@ static void runOldPMPasses(Config &Conf, Module &Mod, TargetMachine *TM,
bool opt(Config &Conf, TargetMachine *TM, unsigned Task, Module &Mod,
bool IsThinLto) {
Mod.setDataLayout(TM->createDataLayout());
runOldPMPasses(Conf, Mod, TM, IsThinLto);
if (Conf.OptPipeline.empty())
runOldPMPasses(Conf, Mod, TM, IsThinLto);
else
runNewPMCustomPasses(Mod, TM, Conf.OptPipeline, Conf.DisableVerify);
return !Conf.PostOptModuleHook || Conf.PostOptModuleHook(Task, Mod);
}

Expand Down
24 changes: 24 additions & 0 deletions test/tools/llvm-lto2/X86/pipeline.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
; RUN: llvm-as < %s > %t1.bc

; Try a custom pipeline
; RUN: llvm-lto2 %t1.bc -o %t.o -save-temps \
; RUN: -r %t1.bc,patatino,px -opt-pipeline loweratomic
; RUN: llvm-dis < %t.o.0.4.opt.bc | FileCheck %s --check-prefix=CUSTOM

target triple = "x86_64-unknown-linux-gnu"

define void @patatino() {
fence seq_cst
ret void
}

; CUSTOM: define void @patatino() {
; CUSTOM-NEXT: ret void
; CUSTOM-NEXT: }

; Check that invalid pipeline are caught as errors.
; RUN: not llvm-lto2 %t1.bc -o %t.o -save-temps \
; RUN: -r %t1.bc,patatino,px -opt-pipeline foogoo 2>&1 | \
; RUN: FileCheck %s --check-prefix=ERR

; ERR: LLVM ERROR: unable to parse pass pipeline description: foogoo
7 changes: 7 additions & 0 deletions tools/llvm-lto2/llvm-lto2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ static cl::opt<std::string> OutputFilename("o", cl::Required,
static cl::opt<std::string> CacheDir("cache-dir", cl::desc("Cache Directory"),
cl::value_desc("directory"));

static cl::opt<std::string> OptPipeline("opt-pipeline",
cl::desc("Optimizer Pipeline"),
cl::value_desc("pipeline"));

static cl::opt<bool> SaveTemps("save-temps", cl::desc("Save temporary files"));

static cl::opt<bool>
Expand Down Expand Up @@ -148,6 +152,9 @@ int main(int argc, char **argv) {
check(Conf.addSaveTemps(OutputFilename + "."),
"Config::addSaveTemps failed");

// Run a custom pipeline, if asked for.
Conf.OptPipeline = OptPipeline;

ThinBackend Backend;
if (ThinLTODistributedIndexes)
Backend = createWriteIndexesThinBackend("", "", true, "");
Expand Down

0 comments on commit fab897d

Please sign in to comment.