Skip to content

Commit

Permalink
[ORC] Temporarily disable the RPC Error/Expected unit tests while I i…
Browse files Browse the repository at this point in the history 
…nvestigate

bot failures.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@300177 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
@lhames
lhames committed Apr 13, 2017
1 parent e460ede commit 679e173
Showing 1 changed file with 135 additions and 133 deletions.
268 changes: 135 additions & 133 deletions unittests/ExecutionEngine/Orc/RPCUtilsTest.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -551,139 +551,141 @@ TEST(DummyRPC, TestWithAltCustomType) {
ServerThread.join();
}

TEST(DummyRPC, ReturnErrorSuccess) {
registerDummyErrorSerialization<QueueChannel>();

auto Channels = createPairedQueueChannels();
DummyRPCEndpoint Client(*Channels.first);
DummyRPCEndpoint Server(*Channels.second);

std::thread ServerThread([&]() {
Server.addHandler<DummyRPCAPI::ErrorFunc>(
[]() {
return Error::success();
});

// Handle the negotiate plus one call.
for (unsigned I = 0; I != 2; ++I)
cantFail(Server.handleOne());
});

cantFail(Client.callAsync<DummyRPCAPI::ErrorFunc>(
[&](Error Err) {
EXPECT_FALSE(!!Err) << "Expected success value";
return Error::success();
}));

cantFail(Client.handleOne());

ServerThread.join();
}

TEST(DummyRPC, ReturnErrorFailure) {
registerDummyErrorSerialization<QueueChannel>();

auto Channels = createPairedQueueChannels();
DummyRPCEndpoint Client(*Channels.first);
DummyRPCEndpoint Server(*Channels.second);

std::thread ServerThread([&]() {
Server.addHandler<DummyRPCAPI::ErrorFunc>(
[]() {
return make_error<DummyError>(42);
});

// Handle the negotiate plus one call.
for (unsigned I = 0; I != 2; ++I)
cantFail(Server.handleOne());
});

cantFail(Client.callAsync<DummyRPCAPI::ErrorFunc>(
[&](Error Err) {
EXPECT_TRUE(Err.isA<DummyError>())
<< "Incorrect error type";
return handleErrors(
std::move(Err),
[](const DummyError &DE) {
EXPECT_EQ(DE.getValue(), 42ULL)
<< "Incorrect DummyError serialization";
});
}));

cantFail(Client.handleOne());

ServerThread.join();
}

TEST(DummyRPC, ReturnExpectedSuccess) {
registerDummyErrorSerialization<QueueChannel>();

auto Channels = createPairedQueueChannels();
DummyRPCEndpoint Client(*Channels.first);
DummyRPCEndpoint Server(*Channels.second);

std::thread ServerThread([&]() {
Server.addHandler<DummyRPCAPI::ExpectedFunc>(
[]() -> uint32_t {
return 42;
});

// Handle the negotiate plus one call.
for (unsigned I = 0; I != 2; ++I)
cantFail(Server.handleOne());
});

cantFail(Client.callAsync<DummyRPCAPI::ExpectedFunc>(
[&](Expected<uint32_t> ValOrErr) {
EXPECT_TRUE(!!ValOrErr)
<< "Expected success value";
EXPECT_EQ(*ValOrErr, 42ULL)
<< "Incorrect Expected<uint32_t> deserialization";
return Error::success();
}));

cantFail(Client.handleOne());

ServerThread.join();
}

TEST(DummyRPC, ReturnExpectedFailure) {
registerDummyErrorSerialization<QueueChannel>();

auto Channels = createPairedQueueChannels();
DummyRPCEndpoint Client(*Channels.first);
DummyRPCEndpoint Server(*Channels.second);

std::thread ServerThread([&]() {
Server.addHandler<DummyRPCAPI::ExpectedFunc>(
[]() -> Expected<uint32_t> {
return make_error<DummyError>(7);
});

// Handle the negotiate plus one call.
for (unsigned I = 0; I != 2; ++I)
cantFail(Server.handleOne());
});

cantFail(Client.callAsync<DummyRPCAPI::ExpectedFunc>(
[&](Expected<uint32_t> ValOrErr) {
EXPECT_FALSE(!!ValOrErr)
<< "Expected failure value";
auto Err = ValOrErr.takeError();
EXPECT_TRUE(Err.isA<DummyError>())
<< "Incorrect error type";
return handleErrors(
std::move(Err),
[](const DummyError &DE) {
EXPECT_EQ(DE.getValue(), 7ULL)
<< "Incorrect DummyError serialization";
});
}));

cantFail(Client.handleOne());

ServerThread.join();
}
// FIXME: Temporarily disabled to investigate bot failure.

// TEST(DummyRPC, ReturnErrorSuccess) {
// registerDummyErrorSerialization<QueueChannel>();

// auto Channels = createPairedQueueChannels();
// DummyRPCEndpoint Client(*Channels.first);
// DummyRPCEndpoint Server(*Channels.second);

// std::thread ServerThread([&]() {
// Server.addHandler<DummyRPCAPI::ErrorFunc>(
// []() {
// return Error::success();
// });

// // Handle the negotiate plus one call.
// for (unsigned I = 0; I != 2; ++I)
// cantFail(Server.handleOne());
// });

// cantFail(Client.callAsync<DummyRPCAPI::ErrorFunc>(
// [&](Error Err) {
// EXPECT_FALSE(!!Err) << "Expected success value";
// return Error::success();
// }));

// cantFail(Client.handleOne());

// ServerThread.join();
// }

// TEST(DummyRPC, ReturnErrorFailure) {
// registerDummyErrorSerialization<QueueChannel>();

// auto Channels = createPairedQueueChannels();
// DummyRPCEndpoint Client(*Channels.first);
// DummyRPCEndpoint Server(*Channels.second);

// std::thread ServerThread([&]() {
// Server.addHandler<DummyRPCAPI::ErrorFunc>(
// []() {
// return make_error<DummyError>(42);
// });

// // Handle the negotiate plus one call.
// for (unsigned I = 0; I != 2; ++I)
// cantFail(Server.handleOne());
// });

// cantFail(Client.callAsync<DummyRPCAPI::ErrorFunc>(
// [&](Error Err) {
// EXPECT_TRUE(Err.isA<DummyError>())
// << "Incorrect error type";
// return handleErrors(
// std::move(Err),
// [](const DummyError &DE) {
// EXPECT_EQ(DE.getValue(), 42ULL)
// << "Incorrect DummyError serialization";
// });
// }));

// cantFail(Client.handleOne());

// ServerThread.join();
// }

// TEST(DummyRPC, ReturnExpectedSuccess) {
// registerDummyErrorSerialization<QueueChannel>();

// auto Channels = createPairedQueueChannels();
// DummyRPCEndpoint Client(*Channels.first);
// DummyRPCEndpoint Server(*Channels.second);

// std::thread ServerThread([&]() {
// Server.addHandler<DummyRPCAPI::ExpectedFunc>(
// []() -> uint32_t {
// return 42;
// });

// // Handle the negotiate plus one call.
// for (unsigned I = 0; I != 2; ++I)
// cantFail(Server.handleOne());
// });

// cantFail(Client.callAsync<DummyRPCAPI::ExpectedFunc>(
// [&](Expected<uint32_t> ValOrErr) {
// EXPECT_TRUE(!!ValOrErr)
// << "Expected success value";
// EXPECT_EQ(*ValOrErr, 42ULL)
// << "Incorrect Expected<uint32_t> deserialization";
// return Error::success();
// }));

// cantFail(Client.handleOne());

// ServerThread.join();
// }

// TEST(DummyRPC, ReturnExpectedFailure) {
// registerDummyErrorSerialization<QueueChannel>();

// auto Channels = createPairedQueueChannels();
// DummyRPCEndpoint Client(*Channels.first);
// DummyRPCEndpoint Server(*Channels.second);

// std::thread ServerThread([&]() {
// Server.addHandler<DummyRPCAPI::ExpectedFunc>(
// []() -> Expected<uint32_t> {
// return make_error<DummyError>(7);
// });

// // Handle the negotiate plus one call.
// for (unsigned I = 0; I != 2; ++I)
// cantFail(Server.handleOne());
// });

// cantFail(Client.callAsync<DummyRPCAPI::ExpectedFunc>(
// [&](Expected<uint32_t> ValOrErr) {
// EXPECT_FALSE(!!ValOrErr)
// << "Expected failure value";
// auto Err = ValOrErr.takeError();
// EXPECT_TRUE(Err.isA<DummyError>())
// << "Incorrect error type";
// return handleErrors(
// std::move(Err),
// [](const DummyError &DE) {
// EXPECT_EQ(DE.getValue(), 7ULL)
// << "Incorrect DummyError serialization";
// });
// }));

// cantFail(Client.handleOne());

// ServerThread.join();
// }

TEST(DummyRPC, TestParallelCallGroup) {
auto Channels = createPairedQueueChannels();
Expand Down

0 comments on commit 679e173

Please sign in to comment.