Skip to content

Commit

Permalink
Force emit a relocation for @gnu_indirect_function symbols so that th…
Browse files Browse the repository at this point in the history
…e indirect

resolution works.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198780 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
rdivacky committed Jan 8, 2014
1 parent adc537e commit edc4b60
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/MC/ELFObjectWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,7 @@ ELFObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm,
const MCFragment &FB,
bool InSet,
bool IsPCRel) const {
if (DataA.getFlags() & ELF_STB_Weak)
if (DataA.getFlags() & ELF_STB_Weak || MCELF::GetType(DataA) == ELF::STT_GNU_IFUNC)
return false;
return MCObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl(
Asm, DataA, FB,InSet, IsPCRel);
Expand Down
16 changes: 16 additions & 0 deletions test/MC/ELF/ifunc-reloc.s
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | llvm-readobj -r | FileCheck %s
.global sym
.type sym, @gnu_indirect_function
alias:
.global alias
.type alias, @function
.set sym, alias


callq sym

// CHECK: Relocations [
// CHECK-NEXT: Section (2) .rela.text {
// CHECK-NEXT: 0x1 R_X86_64_PC32 sym 0xFFFFFFFFFFFFFFFC
// CHECK-NEXT: }
// CHECK-NEXT: ]

0 comments on commit edc4b60

Please sign in to comment.