src/goToolsInformation: require go1.13+ for gopls

Gopls v0.8.0+ will require go1.13+ for build. And, skip gopls shouldUpdateLanguageServer check. Fixes golang#2030 Change-Id: If8fdc14553337c4a9bb3f8caae15ace2aa60e0eb Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/381214 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Robert Findley <[email protected]>
yydounai1234 · Jan 28, 2022 · d5403b9 · d5403b9
1 parent 0a9d740
commit d5403b9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/goLanguageServer.ts b/src/goLanguageServer.ts
@@ -1072,6 +1072,12 @@ export async function shouldUpdateLanguageServer(
 		return null;
 	}
 
+	// If the Go version is too old, don't update.
+	const goVersion = await getGoVersion();
+	if (!goVersion || (tool.minimumGoVersion && goVersion.lt(tool.minimumGoVersion.format()))) {
+		return null;
+	}
+
 	// First, run the "gopls version" command and parse its results.
 	// TODO(rstambler): Confirm that the gopls binary's modtime matches the
 	// modtime in the config. Update it if needed.

diff --git a/src/goToolsInformation.ts b/src/goToolsInformation.ts
@@ -202,7 +202,7 @@ export const allToolsInformation: { [key: string]: Tool } = {
 		isImportant: true,
 		description: 'Language Server from Google',
 		usePrereleaseInPreviewMode: true,
-		minimumGoVersion: semver.coerce('1.12'),
+		minimumGoVersion: semver.coerce('1.13'),
 		latestVersion: semver.parse('v0.7.5'),
 		latestVersionTimestamp: moment('2022-01-18', 'YYYY-MM-DD'),
 		latestPrereleaseVersion: semver.parse('v0.7.5'),

diff --git a/test/testdata/helloWorldServer/go.mod b/test/testdata/helloWorldServer/go.mod
@@ -1,3 +1,3 @@
 module hello-world
 
-go 1.12
+go 1.13
diff --git a/tools/allTools.ts.in b/tools/allTools.ts.in
@@ -200,7 +200,7 @@ export const allToolsInformation: { [key: string]: Tool } = {
 		isImportant: true,
 		description: 'Language Server from Google',
 		usePrereleaseInPreviewMode: true,
-		minimumGoVersion: semver.coerce('1.12'),
+		minimumGoVersion: semver.coerce('1.13'),
 		latestVersion: semver.parse('%s'),
 		latestVersionTimestamp: moment('%s', 'YYYY-MM-DD'),
 		latestPrereleaseVersion: semver.parse('%s'),