handle specific casese with appending

zafisoft · May 5, 2014 · 43520f2 · 43520f2
1 parent 30cf675
commit 43520f2
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 6 deletions.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -19,13 +19,25 @@ fn.append = function(appended) {
         length = this.length,
         setter;
 
+    // create jBone object and then append
     if (isString(appended) && rquickExpr.exec(appended)) {
         appended = jBone(appended);
-    } else if (!isObject(appended)) {
+    }
+    // create text node for inserting
+    else if (!isObject(appended)) {
         appended = document.createTextNode(appended);
     }
 
-    if (appended instanceof jBone) {
+    // just append NodeElement
+    if (appended instanceof Node) {
+        setter = function(el) {
+            el.appendChild(appended);
+        };
+    }
+    // wrap object by jBone, and then append
+    else {
+        appended = appended instanceof jBone ? appended : jBone(appended);
+
         setter = function(el, i) {
             appended.forEach(function(node) {
                 if (i) {
@@ -35,10 +47,6 @@ fn.append = function(appended) {
                 }
             });
         };
-    } else if (appended instanceof Node) {
-        setter = function(el) {
-            el.appendChild(appended);
-        };
     }
 
     for (; i < length; i++) {

diff --git a/test/manipulation.js b/test/manipulation.js
@@ -82,6 +82,18 @@ describe('jBone Manipulation', function() {
         expect(a.find('span')).to.have.length(2);
     });
 
+    it('append(NodeList)', function() {
+        var a = jBone('<div>'),
+            f = document.createDocumentFragment();
+
+        f.appendChild(document.createElement('span'));
+        f.appendChild(document.createElement('span'));
+
+        a.append(f.childNodes);
+
+        expect(a.find('span')).to.have.length(2);
+    });
+
     it('append(text)', function() {
         var a = jBone('<div>');