Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #10

Merged
merged 2 commits into from
May 11, 2020
Merged

Fix warnings #10

merged 2 commits into from
May 11, 2020

Conversation

spickermann
Copy link
Contributor

Should remove these warnings:

gems/zaikio-directory-0.0.7/lib/zaikio/error.rb:8: warning: already initialized constant Spyke::ConnectionError
gems/spyke-5.3.4/lib/spyke/exceptions.rb:3: warning: previous definition of ConnectionError was here
gems/zaikio-directory-0.0.7/lib/zaikio/error.rb:9: warning: already initialized constant Spyke::ResourceNotFound
gems/spyke-5.3.4/lib/spyke/exceptions.rb:2: warning: previous definition of ResourceNotFound was here

Feel free to merge and push to Rubygems. Btw you might want to:

gem owner zaikio-directory -a [email protected]
gem owner zaikio-jwt_auth -a [email protected]

@spickermann spickermann requested a review from jalyna May 11, 2020 12:54
Copy link
Member

@jalyna jalyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative! I will have also a closer look!

@jalyna jalyna merged commit 2cad326 into master May 11, 2020
@jalyna jalyna deleted the fix-deprecation-warnings branch May 11, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants