forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(orm): gRPC codes for save errors (cosmos#11386)
## Description Ref: cosmos#11088. First PR of several to add gRPC error codes and make sure that errors are a well-defined part of the API. Also introduces Cucumber-style BDD acceptance tests into the SDK via https://github.com/regen-network/gocuke. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
- Loading branch information
Showing
13 changed files
with
1,050 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| Feature: inserting, updating and saving entities | ||
|
|
||
| Scenario: can't insert an entity with a duplicate primary key | ||
| Given an existing entity | ||
| """ | ||
| {"name": "foo", "not_unique": "bar"} | ||
| """ | ||
| When I insert | ||
| """ | ||
| {"name": "foo", "not_unique": "baz"} | ||
| """ | ||
| Then expect a "already exists" error | ||
| And expect grpc error code "ALREADY_EXISTS" | ||
|
|
||
| Scenario: can't update entity that doesn't exist | ||
| When I update | ||
| """ | ||
| {"name":"foo"} | ||
| """ | ||
| Then expect a "not found" error | ||
| And expect grpc error code "NOT_FOUND" | ||
| # | ||
| Scenario: can't violate unique constraint on insert | ||
| Given an existing entity | ||
| """ | ||
| {"name": "foo", "unique": "bar"} | ||
| """ | ||
| When I insert | ||
| """ | ||
| {"name": "baz", "unique": "bar"} | ||
| """ | ||
| Then expect a "unique key violation" error | ||
| And expect grpc error code "FAILED_PRECONDITION" | ||
|
|
||
| Scenario: can't violate unique constraint on update | ||
| Given an existing entity | ||
| """ | ||
| {"name": "foo", "unique": "bar"} | ||
| """ | ||
| And an existing entity | ||
| """ | ||
| {"name": "baz", "unique": "bam"} | ||
| """ | ||
| When I update | ||
| """ | ||
| {"name": "baz", "unique": "bar"} | ||
| """ | ||
| Then expect a "unique key violation" error | ||
| And expect grpc error code "FAILED_PRECONDITION" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.