remove extra redundant channels setup in iOS embedding engine (flutte…

…r#11886)
zanderso · Sep 5, 2019 · dd71e7b · dd71e7b
1 parent 4243324
commit dd71e7b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm b/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
@@ -93,7 +93,6 @@ - (instancetype)initWithName:(NSString*)labelPrefix
   _pluginPublications = [NSMutableDictionary new];
   _platformViewsController.reset(new flutter::FlutterPlatformViewsController());
 
-  [self setupChannels];
   _binaryMessenger = [[FlutterBinaryMessengerRelay alloc] initWithParent:self];
 
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];

diff --git a/testing/scenario_app/ios/Scenarios/ScenariosTests/FlutterEngineTest.m b/testing/scenario_app/ios/Scenarios/ScenariosTests/FlutterEngineTest.m
@@ -28,4 +28,23 @@ - (void)testIsolateId {
   XCTAssertNil(engine.isolateId);
 }
 
+- (void)testChannelSetup {
+  FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"test" project:nil];
+  XCTAssertNil(engine.navigationChannel);
+  XCTAssertNil(engine.platformChannel);
+  XCTAssertNil(engine.lifecycleChannel);
+
+  XCTAssertTrue([engine runWithEntrypoint:nil]);
+
+  XCTAssertNotNil(engine.navigationChannel);
+  XCTAssertNotNil(engine.platformChannel);
+  XCTAssertNotNil(engine.lifecycleChannel);
+
+  [engine destroyContext];
+
+  XCTAssertNil(engine.navigationChannel);
+  XCTAssertNil(engine.platformChannel);
+  XCTAssertNil(engine.lifecycleChannel);
+}
+
 @end