there is no need to nil the app.settings on ResetBootstrapState

zaniar · Sep 1, 2023 · 78e70bd · 78e70bd
1 parent 5840145
commit 78e70bd
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/core/base.go b/core/base.go
@@ -375,7 +375,6 @@ func (app *BaseApp) ResetBootstrapState() error {
 
 	app.dao = nil
 	app.logsDao = nil
-	app.settings = nil
 
 	return nil
 }

diff --git a/core/base_test.go b/core/base_test.go
@@ -118,10 +118,6 @@ func TestBaseAppBootstrap(t *testing.T) {
 	if app.logsDao != nil {
 		t.Fatalf("Expected app.logsDao to be nil, got %v.", app.logsDao)
 	}
-
-	if app.settings != nil {
-		t.Fatalf("Expected app.settings to be nil, got %v.", app.settings)
-	}
 }
 
 func TestBaseAppGetters(t *testing.T) {