[release] debugAdapter: fix a bug where we are not sending back confi…

…guration done response This change is to address this bug: eclipse-theia/theia#8455. The Go extension is not able to continue past after hitting the breakpoint because `setConfigurationDoneRequest` is not sending back a response if the program is already running. This keeps Theia waiting for the response (which it never receives!). Change-Id: Ie416638793d4c4505d9dd6b9e34753b60188ac5d GitHub-Last-Rev: 5423aae GitHub-Pull-Request: golang#641 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254959 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Quoc Truong <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> (cherry picked from commit 29cee47) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/255677 Reviewed-by: Quoc Truong <[email protected]>
zarej · Sep 17, 2020 · dfefea0 · dfefea0
1 parent 6f67a37
commit dfefea0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/debugAdapter/goDebug.ts b/src/debugAdapter/goDebug.ts
@@ -872,13 +872,15 @@ export class GoDebugSession extends LoggingDebugSession {
 		if (this.stopOnEntry) {
 			this.sendEvent(new StoppedEvent('entry', 1));
 			log('StoppedEvent("entry")');
-			this.sendResponse(response);
 		} else {
 			this.debugState = await this.delve.getDebugState();
 			if (!this.debugState.Running) {
-				this.continueRequest(<DebugProtocol.ContinueResponse>response);
+				log('Changing DebugState from Halted to Running');
+				this.continue();
 			}
 		}
+		this.sendResponse(response);
+		log('ConfigurationDoneResponse', response);
 	}
 
 	/**