Allow compressors to be registered with CompressorFactory #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@melissalinkert: leaving this out of 0.4.0 based on your final comment, but cc'ing @pedson in case he has ideas. Happy to roll a quick 0.5.0 if it's deemed worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from glencoesoftware#4, as suggested by @joshmoore.
This makes some minimal changes to allow compressors other than zlib and blosc to be registered, and adds a corresponding test case. No new compression types are supported here, this is just one way to make the compression types more extensible.
I wouldn't necessarily expect this to be merged as-is, and would be happy to hear other thoughts on how to implement this feature.