Skip to content

Commit

Permalink
ipv6: sr: fix useless rol32 call on hash
Browse files Browse the repository at this point in the history
The rol32 call is currently rotating hash but the rol'd value is
being discarded. I believe the current code is incorrect and hash
should be assigned the rotated value returned from rol32.

Detected by CoverityScan, CID#1468411 ("Useless call")

Fixes: b5facfd ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode")
Signed-off-by: Colin Ian King <[email protected]>
Acked-by: [email protected]
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Colin Ian King authored and davem330 committed Jul 18, 2018
1 parent 9640ccc commit 3ee593a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv6/seg6_iptunnel.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static __be32 seg6_make_flowlabel(struct net *net, struct sk_buff *skb,

if (do_flowlabel > 0) {
hash = skb_get_hash(skb);
rol32(hash, 16);
hash = rol32(hash, 16);
flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK;
} else if (!do_flowlabel && skb->protocol == htons(ETH_P_IPV6)) {
flowlabel = ip6_flowlabel(inner_hdr);
Expand Down

0 comments on commit 3ee593a

Please sign in to comment.