adjusted nostrichat component code #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Code looks good actually – the group ID hex is the problem I think. Where did that come from? Where did you great the group? |
|
@zatzby actually –the id/room shows up on nostrchat.io so I'm not sure what's going on. My guess, since the nostri.chat codebase hasn't been updated since June is that it's a bug on that side. |
|
Thank you for feedback. I'll try with another room id, and/or with another account to check and see if I can get it to work. |
|
If it doesn’t work, I’d strongly suggest opening an issue on nostrichat’s GitHub and bothering Pablo. :)
… On Sep 29, 2023, at 07:37, zach ***@***.***> wrote:
Thank you for feedback. I'll try with another room id, and/or with another account to check and see if I can get it to work.
—
Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRRACSBWXRWYWOR5FTPMLX4ZNDPANCNFSM6AAAAAA5G2CYCY>.
You are receiving this because your review was requested.
|
|
haha sounds good! Will check and then create an issue asap if necessary. Although I feel like an ant on an elephant with all the work guys like him and you are doing! 😂😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jeff, I am trying different approaches to the nostrichat component to try to get it to function.
I am reviewing the code at Pablo's repository here: https://github.com/pablof7z/nostr-chat-widget
I have also looked here: https://nostri.chat/
Although nostri.chat says the widget can be dropped into html code simply, it seems since we are using svelte it has to modeled like the nostr-chat-widget repo with adapters and the like? Is my logic right?
Should I attempt to rebuild the repo structure that Pablo has? Or at least rebuild some portion of the src components in the image here? Any help and guidance would be greatly appreciated -- I am a bit out over my skis!
