remove warning from rollback in adapter

zblanco · Oct 30, 2022 · c978657 · c978657
1 parent fd208ac
commit c978657
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -74,9 +74,9 @@ jobs:
 
       - name: Run tests spawn_statestores
         run: |
-          cd spawn_statestores/statestores
+          cd spawn_statestores/statestores_mysql
           mix deps.get
-          MIX_ENV=test PROXY_DATABASE_TYPE=mysql PROXY_CLUSTER_STRATEGY=epmd PROXY_HTTP_PORT=9005 SPAWN_STATESTORE_KEY=3Jnb0hZiHIzHTOih7t2cTEPEpY98Tu1wvQkPfq/XwqE= elixir --name [email protected] -S mix test
+          MIX_ENV=test PROXY_CLUSTER_STRATEGY=epmd PROXY_HTTP_PORT=9005 SPAWN_STATESTORE_KEY=3Jnb0hZiHIzHTOih7t2cTEPEpY98Tu1wvQkPfq/XwqE= elixir --name [email protected] -S mix test
           cd ../../
 
       - name: Run tests proxy

diff --git a/spawn_statestores/statestores/lib/statestores/adapters/behaviour.ex b/spawn_statestores/statestores/lib/statestores/adapters/behaviour.ex
@@ -13,7 +13,7 @@ defmodule Statestores.Adapters.Behaviour do
 
   @callback migrate :: {:ok, any(), any()}
 
-  @callback rollback(term()) :: {:ok, any(), any()}
+  @callback rollback_migration(term()) :: {:ok, any(), any()}
 
   defmacro __using__(_opts) do
     quote do

diff --git a/spawn_statestores/statestores/lib/statestores/migrator/migrator.ex b/spawn_statestores/statestores/lib/statestores/migrator/migrator.ex
@@ -12,6 +12,6 @@ defmodule Statestores.Migrator do
   def rollback(adapter, version) do
     load_app()
 
-    adapter.rollback(version)
+    adapter.rollback_migration(version)
   end
 end
diff --git a/spawn_statestores/statestores_cockroachdb/lib/statestores/adapters/cockroachdb.ex b/spawn_statestores/statestores_cockroachdb/lib/statestores/adapters/cockroachdb.ex
@@ -42,7 +42,7 @@ defmodule Statestores.Adapters.CockroachDB do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :up, all: true))
   end
 
-  def rollback(version) do
+  def rollback_migration(version) do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :down, to: version))
   end
 end
diff --git a/spawn_statestores/statestores_mssql/lib/statestores/adapters/mssql.ex b/spawn_statestores/statestores_mssql/lib/statestores/adapters/mssql.ex
@@ -46,7 +46,7 @@ defmodule Statestores.Adapters.MSSQL do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :up, all: true))
   end
 
-  def rollback(version) do
+  def rollback_migration(version) do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :down, to: version))
   end
 end
diff --git a/spawn_statestores/statestores_mysql/lib/statestores/adapters/mysql.ex b/spawn_statestores/statestores_mysql/lib/statestores/adapters/mysql.ex
@@ -41,7 +41,7 @@ defmodule Statestores.Adapters.MySQL do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :up, all: true))
   end
 
-  def rollback(version) do
+  def rollback_migration(version) do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :down, to: version))
   end
 end
diff --git a/spawn_statestores/statestores_postgres/lib/statestores/adapters/postgres.ex b/spawn_statestores/statestores_postgres/lib/statestores/adapters/postgres.ex
@@ -42,7 +42,7 @@ defmodule Statestores.Adapters.Postgres do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :up, all: true))
   end
 
-  def rollback(version) do
+  def rollback_migration(version) do
     {:ok, _, _} = Ecto.Migrator.with_repo(__MODULE__, &Ecto.Migrator.run(&1, :down, to: version))
   end
 end