Update no path notification content.

zdnuist · Dec 13, 2018 · 4a3cbb5 · 4a3cbb5
1 parent 8f7c2cd
commit 4a3cbb5
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 10 deletions.
diff --git a/arouter-idea-plugin/src/main/kotlin/com/alibaba/android/arouter/idea/extensions/Const.kt b/arouter-idea-plugin/src/main/kotlin/com/alibaba/android/arouter/idea/extensions/Const.kt
@@ -0,0 +1,23 @@
+package com.alibaba.android.arouter.idea.extensions
+
+import com.intellij.openapi.util.IconLoader
+
+/**
+ * Const of plugin
+ *
+ * @author zhilong <a href="mailto:[email protected]">Contact me.</a>
+ * @version 1.0
+ * @since 2018/12/13 8:06 PM
+ */
+object Const {
+    const val ROUTE_ANNOTATION_NAME = "com.alibaba.android.arouter.facade.annotation.Route"
+    const val SDK_NAME = "ARouter"
+
+    // Notify
+    const val NOTIFY_SERVICE_NAME = "ARouter Plugin Tips"
+    const val NOTIFY_TITLE = "Road Sign"
+    const val NOTIFY_NO_TARGET_TIPS = "No destination found or unsupported type."
+
+    val navigationOnIcon = IconLoader.getIcon("icon/outline-location_on-24px.svg")
+    val navigationOffIcon = IconLoader.getIcon("icon/outline-location_off-24px.svg")
+}
diff --git a/...lugin/src/main/kotlin/com/alibaba/android/arouter/idea/extensions/NavigationLineMarker.kt b/...lugin/src/main/kotlin/com/alibaba/android/arouter/idea/extensions/NavigationLineMarker.kt
@@ -1,12 +1,20 @@
 package com.alibaba.android.arouter.idea.extensions
 
+import com.alibaba.android.arouter.idea.extensions.Const.NOTIFY_NO_TARGET_TIPS
+import com.alibaba.android.arouter.idea.extensions.Const.NOTIFY_SERVICE_NAME
+import com.alibaba.android.arouter.idea.extensions.Const.NOTIFY_TITLE
+import com.alibaba.android.arouter.idea.extensions.Const.ROUTE_ANNOTATION_NAME
+import com.alibaba.android.arouter.idea.extensions.Const.SDK_NAME
+import com.alibaba.android.arouter.idea.extensions.Const.navigationOnIcon
 import com.intellij.codeHighlighting.Pass
 import com.intellij.codeInsight.daemon.GutterIconNavigationHandler
 import com.intellij.codeInsight.daemon.LineMarkerInfo
 import com.intellij.codeInsight.daemon.LineMarkerProviderDescriptor
 import com.intellij.navigation.NavigationItem
+import com.intellij.notification.Notification
+import com.intellij.notification.NotificationType
+import com.intellij.notification.Notifications
 import com.intellij.openapi.editor.markup.GutterIconRenderer
-import com.intellij.openapi.util.IconLoader
 import com.intellij.psi.*
 import com.intellij.psi.impl.source.tree.java.PsiMethodCallExpressionImpl
 import com.intellij.psi.search.GlobalSearchScope
@@ -47,17 +55,21 @@ class NavigationLineMarker : LineMarkerProviderDescriptor(), GutterIconNavigatio
                         ?: return, fullScope).findAll()
                 val target = routeAnnotationWrapper.find {
                     it.annotations.map { it.findAttributeValue("path")?.text?.replace("\"", "") }.contains(targetPath)
-                } ?: return
+                }
 
-                // Redirect to target.
-                NavigationItem::class.java.cast(target).navigate(true)
+                if (null == target) {
+                    Notifications.Bus.notify(Notification(NOTIFY_SERVICE_NAME, NOTIFY_TITLE, NOTIFY_NO_TARGET_TIPS, NotificationType.WARNING))
+                } else {
+                    // Redirect to target.
+                    NavigationItem::class.java.cast(target).navigate(true)
+                }
             }
         }
     }
 
     private fun getAnnotationWrapper(psiElement: PsiElement?, scope: GlobalSearchScope): PsiClass? {
         if (null == routeAnnotationWrapper) {
-            routeAnnotationWrapper = JavaPsiFacade.getInstance(psiElement?.project).findClass(routeAnnotationRef, scope)
+            routeAnnotationWrapper = JavaPsiFacade.getInstance(psiElement?.project).findClass(ROUTE_ANNOTATION_NAME, scope)
         }
 
         return routeAnnotationWrapper
@@ -87,19 +99,16 @@ class NavigationLineMarker : LineMarkerProviderDescriptor(), GutterIconNavigatio
      */
     private fun isClassOfARouter(psiClass: PsiClass): Boolean {
         // It was ARouter
-        if (psiClass.name.equals("ARouter")) {
+        if (psiClass.name.equals(SDK_NAME)) {
             return true
         }
 
         // It super class was ARouter
-        psiClass.supers.find { it.name == "ARouter" } ?: return false
+        psiClass.supers.find { it.name == SDK_NAME } ?: return false
 
         return true
     }
 
-    private val routeAnnotationRef = "com.alibaba.android.arouter.facade.annotation.Route"
     // I'm 100% sure this point can not made memory leak.
     private var routeAnnotationWrapper: PsiClass? = null
-    private val navigationOnIcon = IconLoader.getIcon("icon/outline-location_on-24px.svg")
-    private val navigationOffIcon = IconLoader.getIcon("icon/outline-location_off-24px.svg")
 }