Fix bad return for failed attachment

Add test for failing attachment
zeandcode · Jun 6, 2013 · 2032af0 · 2032af0
1 parent d852751
commit 2032af0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/class.phpmailer.php b/class.phpmailer.php
@@ -1806,9 +1806,7 @@ public function AddAttachment($path, $name = '', $encoding = 'base64', $type = '
       if ($this->SMTPDebug) {
         $this->edebug($e->getMessage()."\n");
       }
-      if ( $e->getCode() == self::STOP_CRITICAL ) {
-        return false;
-      }
+      return false;
     }
     return true;
   }

diff --git a/test/phpmailerTest.php b/test/phpmailerTest.php
@@ -125,8 +125,9 @@ function tearDown()
 
     /**
      * Build the body of the message in the appropriate format.
+     *
      * @private
-     * @returns void
+     * @return void
      */
     function BuildBody()
     {
@@ -202,7 +203,7 @@ function BuildBody()
     /**
      * Check which default settings have been changed for the report.
      * @private
-     * @returns void
+     * @return void
      */
     function CheckChanges()
     {
@@ -769,6 +770,9 @@ function test_HTML_Attachment()
             return;
         }
 
+        //Make sure that trying to attach a nonexistent file fails
+        $this->assertFalse($this->Mail->AddAttachment(__FILE__.md5(microtime()), 'nonexistent_file.txt'));
+
         $this->BuildBody();
         $this->assertTrue($this->Mail->Send(), $this->Mail->ErrorInfo);
     }