Unbreak gcc builds #2493
Merged
Unbreak gcc builds #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadmic
reviewed
Mar 1, 2025
|
|
||
| #include "global.h" | ||
| #include "libc64/sleep.h" | ||
| #include "libc64/sprintf.h" | ||
| #include "alloca.h" | ||
| #include "controller.h" | ||
| #include "padmgr.h" |
There was a problem hiding this comment.
is this for a missing declaration? why was it not caught by CC_CHECK?
There was a problem hiding this comment.
Yeah it's for PadMgr_RequestPadData, it wasn't caught since CC_CHECK doesn't define AVOID_UB and we have a wrong prototype defined when AVOID_UB is not defined
There was a problem hiding this comment.
I see, apparently MM defines AVOID_UB for CC_CHECK, maybe we should do the same to get more coverage here
Dragorn421
approved these changes
Mar 1, 2025
|
This unbreaks any modern gcc builds that include fault_gc.c |
cadmic
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.