Skip to content

Commit

Permalink
Enable warn as error in corelib (dotnet#174)
Browse files Browse the repository at this point in the history
Enable warn as error in corelib as the workaround was set for VS2017 which we no longer use since we moved to VS2019 and that's the recommended toolset.
  • Loading branch information
safern authored and ViktorHofer committed Nov 21, 2019
1 parent d5c41a7 commit 31d4ca5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/coreclr/build.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -643,10 +643,8 @@ if %__BuildCoreLib% EQU 1 (
exit /b !errorlevel!
)

REM Disable warnAsError to work around VS bug (948084) where ucrt lib path is not set properly, resulting in CS1668
powershell -NoProfile -ExecutionPolicy ByPass -NoLogo -Command "%__RepoRootDir%\eng\common\msbuild.ps1" %__ArcadeScriptArgs%^
%__ProjectDir%\src\build.proj -warnAsError:0^
/nodeReuse:false /p:PortableBuild=true /maxcpucount^
%__ProjectDir%\src\build.proj /nodeReuse:false /p:PortableBuild=true /maxcpucount^
'!__MsbuildLog!' '!__MsbuildWrn!' '!__MsbuildErr!' %__CommonMSBuildArgs% !__ExtraBuildArgs! %__UnprocessedBuildArgs%
if not !errorlevel! == 0 (
echo %__ErrMsgPrefix%%__MsgPrefix%Error: Managed Product assemblies build failed. Refer to the build log files for details.
Expand Down

0 comments on commit 31d4ca5

Please sign in to comment.