Skip to content

Commit

Permalink
Remove filter for Exception type during registry inquiry. (dotnet/cor…
Browse files Browse the repository at this point in the history
…eclr#24725)

Update Console output with more details.

Commit migrated from dotnet/coreclr@128e5dd
  • Loading branch information
AaronRobinsonMSFT authored May 22, 2019
1 parent 1cf568e commit 40c8e86
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/coreclr/tests/src/Common/CoreCLRTestLibrary/Utilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,9 @@ private static string GetInstallationTypeForWindows()
string value = "InstallationType";
return GetRegistryValueString(key, value);
}
catch (Exception e) when (e is SecurityException || e is InvalidCastException || e is PlatformNotSupportedException /* UAP */)
catch (Exception e)
{
Console.WriteLine($"{nameof(GetInstallationTypeForWindows)} exception: {e}");
return string.Empty;
}
}
Expand Down Expand Up @@ -430,11 +431,11 @@ public static int ExecuteAndUnload(string assemblyPath, string[] args, Action<As
if (alcWeakRef.IsAlive)
{
exitCode += 100;
Console.WriteLine("Unload failed");
Console.WriteLine($"Unload failed - {assemblyPath}");
}
else
{
Console.WriteLine("Unload succeeded");
Console.WriteLine($"Unload succeeded - {assemblyPath}");
}

return exitCode;
Expand Down

0 comments on commit 40c8e86

Please sign in to comment.