Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Animated Dreidel #2896

Merged
merged 4 commits into from
Jan 9, 2025
Merged

3D Animated Dreidel #2896

merged 4 commits into from
Jan 9, 2025

Conversation

RikyShafer
Copy link
Contributor

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

Copy link

🙏 Thanks for your pull request @RikyShafer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2896 269 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 363 3605

Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha and thanks for your contributions.
Please adjust the following:

  • the css file should be named styles.css -> make sure to update the html link accordingly
  • you are missing a meta.json file.
    Please refer to the Readme if necessary

Copy link

🙏 Thanks for your pull request @RikyShafer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2896 269 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 364 3611

Copy link

🙏 Thanks for your pull request @RikyShafer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2896 273 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 364 3611

@LaurelineP
Copy link
Contributor

Aloha @RikyShafer
Thanks for the changes, one last change
Please name your folder as followed -

Copy link

🙏 Thanks for your pull request @RikyShafer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2896 273 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 364 3611

@LaurelineP
Copy link
Contributor

Thanks for your reactivity :) Happy coding 🙌

Copy link

🙏 Thanks for your pull request @RikyShafer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2896 273 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 364 3614

@LaurelineP LaurelineP merged commit 798daec into zero-to-mastery:master Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants