feat: add execution dialect name (eakmanrq#273)

zerodarkzone · Jan 30, 2025 · 5b2b97e · 5b2b97e
1 parent ec19019
commit 5b2b97e
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 0 deletions.
diff --git a/sqlframe/base/session.py b/sqlframe/base/session.py
@@ -108,6 +108,11 @@ def __init__(
         if not getattr(self, "schema", None) or schema:
             self._schema = schema
 
+    # https://github.com/eakmanrq/sqlframe/issues/262
+    @property
+    def execution_dialect_name(self) -> str:
+        return self.execution_dialect.__class__.__name__.lower()
+
     @property
     def read(self) -> READER:
         return self._reader(self)

diff --git a/tests/integration/engines/bigquery/test_bigquery_session.py b/tests/integration/engines/bigquery/test_bigquery_session.py
@@ -18,3 +18,4 @@ def test_session_from_config():
     session = BigQuerySession.builder.config("default_dataset", "sqlframe.db1").getOrCreate()
     columns = session.catalog.get_columns("db1.test_table")
     assert columns == {"cola": exp.DataType.build("BIGINT"), "colb": exp.DataType.build("TEXT")}
+    assert session.execution_dialect_name == "bigquery"
diff --git a/tests/integration/engines/databricks/test_databricks_session.py b/tests/integration/engines/databricks/test_databricks_session.py
@@ -45,3 +45,4 @@ def test_session_from_config(cleanup_connector: DatabricksConnection):
         "cola": exp.DataType.build("INT", dialect=session.output_dialect),
         "colb": exp.DataType.build("STRING", dialect=session.output_dialect),
     }
+    assert session.execution_dialect_name == "databricks"
diff --git a/tests/integration/engines/duck/test_duckdb_session.py b/tests/integration/engines/duck/test_duckdb_session.py
@@ -11,3 +11,4 @@ def test_session_from_config():
     session = DuckDBSession.builder.config("sqlframe.conn", conn).getOrCreate()
     columns = session.catalog.get_columns("test_table")
     assert columns == {"cola": exp.DataType.build("INT"), "colb": exp.DataType.build("TEXT")}
+    assert session.execution_dialect_name == "duckdb"
diff --git a/tests/integration/engines/postgres/test_postgres_session.py b/tests/integration/engines/postgres/test_postgres_session.py
@@ -17,3 +17,4 @@ def test_session_from_config(function_scoped_postgres):
         "cola": exp.DataType.build("INT", dialect=session.output_dialect),
         "colb": exp.DataType.build("STRING", dialect=session.output_dialect),
     }
+    assert session.execution_dialect_name == "postgres"
diff --git a/tests/integration/engines/redshift/test_redshift_session.py b/tests/integration/engines/redshift/test_redshift_session.py
@@ -45,3 +45,4 @@ def test_session_from_config(cleanup_connector: RedshiftConnection):
         "cola": exp.DataType.build("INT", dialect=session.output_dialect),
         "colb": exp.DataType.build("STRING", dialect=session.output_dialect),
     }
+    assert session.execution_dialect_name == "redshift"
diff --git a/tests/integration/engines/snowflake/test_snowflake_session.py b/tests/integration/engines/snowflake/test_snowflake_session.py
@@ -45,3 +45,4 @@ def test_session_from_config(cleanup_connector: SnowflakeConnection):
         "cola": exp.DataType.build("DECIMAL(38, 0)", dialect=session.output_dialect),
         "colb": exp.DataType.build("TEXT", dialect=session.output_dialect),
     }
+    assert session.execution_dialect_name == "snowflake"