Skip to content

Commit

Permalink
Fix Python shebang and license for presubmit_test.py
Browse files Browse the repository at this point in the history
This was missed during review of https://codereview.webrtc.org/3010153002
Having python2 in the shebang makes it fail presubmit locally on Mac.

Disable 'invalid-name' PyLint rule in 3 places to pass presubmit.

NOTRY=True
NOTREECHECKS=True
[email protected]

Bug: none
Change-Id: I85cc5783ba11774792cd8c2f6c0b4ff47ad89270
Reviewed-on: https://webrtc-review.googlesource.com/1566
Commit-Queue: Henrik Kjellander <[email protected]>
Reviewed-by: Patrik Höglund <[email protected]>
Reviewed-by: Henrik Kjellander <[email protected]>
Cr-Commit-Position: refs/heads/master@{#19850}
  • Loading branch information
Henrik Kjellander authored and Commit Bot committed Sep 15, 2017
1 parent 5a6aa4f commit a18a3bf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
12 changes: 10 additions & 2 deletions presubmit_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
#!/usr/bin/env python2
#!/usr/bin/env python

# Copyright 2017 The WebRTC project authors. All Rights Reserved.
#
# Use of this source code is governed by a BSD-style license
# that can be found in the LICENSE file in the root of the source
# tree. An additional intellectual property rights grant can be found
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.

import unittest

import PRESUBMIT
Expand Down Expand Up @@ -37,4 +46,3 @@ def testCommitMessageBugEntryIsNone(self):

if __name__ == '__main__':
unittest.main()

1 change: 1 addition & 0 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ disable=
exec-used,
fixme,
import-error,
invalid-name,
missing-docstring,
no-init,
no-member,
Expand Down

0 comments on commit a18a3bf

Please sign in to comment.