forked from EdgeCloudX/ovn
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
northd: Fix defrag flows for duplicate vips
When adding two SB flows with the same vip but different protocols, only the most recent flow will be added due to the `if` statement: if (!sset_contains(&all_ips, lb_vip->vip_str)) { sset_add(&all_ips, lb_vip->vip_str); This can cause unexpected behaviour when two load balancers with the same VIP (and different protocols) are added to a logical router. This is due to the addition of "protocol" to the match in defrag table flows in a previous commit. Add flow to defrag table for every load-balancer in order to resolve this. Flows for Load Balancers without a port specified are added with priority 100. Flows for Load Balancers with a port specified are added with priority 110. Add a test to check behaviour of Logical Flows when two load balancers of the same VIP are added. This bug was discovered through the OVN CI (ovn-kubernetes.yml). Fixes: 384a7c6 ("northd: Refactor Logical Flows for routers with DNAT/Load Balancers") Signed-off-by: Mark Gray <[email protected]> Acked-by: Dumitru Ceara <[email protected]> Signed-off-by: Numan Siddique <[email protected]>
- Loading branch information
1 parent
509c8e8
commit 0c3afe8
Showing
4 changed files
with
130 additions
and
70 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters