Adapt field name in ValidationBindHandler to a valid ConfigurationPro…

…pertyName Fixes spring-projectsgh-19580
zhangbawan · Jan 10, 2020 · a017b89 · a017b89
1 parent ccf4e1a
commit a017b89
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/...rc/main/java/org/springframework/boot/context/properties/bind/DataObjectPropertyName.java b/...rc/main/java/org/springframework/boot/context/properties/bind/DataObjectPropertyName.java
@@ -21,9 +21,10 @@
  *
  * @author Phillip Webb
  * @author Madhura Bhave
+ * @since 2.2.3
  * @see DataObjectBinder
  */
-abstract class DataObjectPropertyName {
+public abstract class DataObjectPropertyName {
 
 	private DataObjectPropertyName() {
 	}
@@ -33,7 +34,7 @@ private DataObjectPropertyName() {
 	 * @param name the source name
 	 * @return the dashed from
 	 */
-	static String toDashedForm(String name) {
+	public static String toDashedForm(String name) {
 		StringBuilder result = new StringBuilder();
 		String replaced = name.replace('_', '-');
 		for (int i = 0; i < replaced.length(); i++) {

diff --git a/...va/org/springframework/boot/context/properties/bind/validation/ValidationBindHandler.java b/...va/org/springframework/boot/context/properties/bind/validation/ValidationBindHandler.java
@@ -28,6 +28,7 @@
 import org.springframework.boot.context.properties.bind.BindContext;
 import org.springframework.boot.context.properties.bind.BindHandler;
 import org.springframework.boot.context.properties.bind.Bindable;
+import org.springframework.boot.context.properties.bind.DataObjectPropertyName;
 import org.springframework.boot.context.properties.source.ConfigurationProperty;
 import org.springframework.boot.context.properties.source.ConfigurationPropertyName;
 import org.springframework.core.ResolvableType;
@@ -187,7 +188,7 @@ protected Object getActualFieldValue(String field) {
 		}
 
 		private ConfigurationPropertyName getName(String field) {
-			return this.name.append(field);
+			return this.name.append(DataObjectPropertyName.toDashedForm(field));
 		}
 
 		ValidationErrors getValidationErrors() {

diff --git a/...g/springframework/boot/context/properties/bind/validation/ValidationBindHandlerTests.java b/...g/springframework/boot/context/properties/bind/validation/ValidationBindHandlerTests.java
@@ -193,6 +193,14 @@ void bindShouldValidateIfOtherHandlersInChainReplaceErrorWithResult() {
 				.satisfies((ex) -> assertThat(ex.getCause()).hasMessageContaining("years"));
 	}
 
+	@Test
+	void validationErrorsForCamelCaseFieldsShouldContainRejectedValue() {
+		this.sources.add(new MockConfigurationPropertySource("foo.inner.person-age", 2));
+		BindValidationException cause = bindAndExpectValidationError(() -> this.binder
+				.bind(ConfigurationPropertyName.of("foo"), Bindable.of(ExampleCamelCase.class), this.handler));
+		assertThat(cause.getMessage()).contains("rejected value [2]");
+	}
+
 	private BindValidationException bindAndExpectValidationError(Runnable action) {
 		try {
 			action.run();
@@ -305,6 +313,33 @@ void setAddress(String address) {
 
 	}
 
+	@Validated
+	static class ExampleCamelCase {
+
+		@Valid
+		private InnerProperties inner = new InnerProperties();
+
+		InnerProperties getInner() {
+			return this.inner;
+		}
+
+		static class InnerProperties {
+
+			@Min(5)
+			private int personAge;
+
+			int getPersonAge() {
+				return this.personAge;
+			}
+
+			void setPersonAge(int personAge) {
+				this.personAge = personAge;
+			}
+
+		}
+
+	}
+
 	@Validated
 	static class ExampleValidatedBeanWithGetterException {