Skip to content

Commit

Permalink
Merge pull request kubernetes#878 from stevekuznetsov/skuznets/update…
Browse files Browse the repository at this point in the history
…-owners

Update OWNERS documents to reflect recent changes
  • Loading branch information
spiffxp authored Aug 8, 2017
2 parents 181cbd1 + 416a7f8 commit 62cc217
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions contributors/devel/owners.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ OWNERS files are in YAML format and support the following keys:

- `approvers`: a list of GitHub usernames or aliases that can `/approve` a PR
- [DEPRECATED] `assignees`: do not use, equivalent to `approvers`
([kubernetes/test-infra#3851](https://github.com/kubernetes/test-infra/issues/3851))
([kubernetes/test-infra#3851](https://github.com/kubernetes/test-infra/issues/3851))
- `labels`: a list of GitHub labels to automatically apply to a PR
- `reviewers`: a list of GitHub usernames or aliases that are good candidates to `/lgtm` a PR

Expand All @@ -41,7 +41,7 @@ approvers:
- alice
- bob # this is a comment
reviewers:
- alice
- alice
- carol # this is another comment
- sig-foo # this is an alias
```
Expand All @@ -57,7 +57,7 @@ publicly auditable.

A sample OWNERS_ALISES file looks like:

```
```
aliases:
sig-foo:
- david
Expand All @@ -67,6 +67,8 @@ aliases:
- frank
```

GitHub usernames and aliases listed in OWNERS files are case-insensitive.

## Code Review Process

This is a simplified description of our [full PR testing and merge
Expand Down Expand Up @@ -153,7 +155,7 @@ is the state of today.
- This hurts the project in general as its general noise level increases over time
- Instead, close PR's that are untouched after too long (we currently have a bot do this after 90
days)

## Implementation

### [`mungegithub`](https://github.com/kubernetes/test-infra/tree/master/mungegithub)
Expand Down Expand Up @@ -185,7 +187,7 @@ stateful, in that restarting it means it loses track of which things it has mung
- [full description of the
algorithm](https://github.com/kubernetes/test-infra/blob/6f5df70c29528db89d07106a8156411068518cbc/mungegithub/mungers/approval-handler.go#L99-L111)
- [munger:
submit-queue](https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/submit-queue.go)
submit-queue](https://github.com/kubernetes/test-infra/blob/master/mungegithub/mungers/submit-queue.go)
- responsible for merging PR's
- responsible for updating a GitHub status check explaining why a PR can't be merged (eg: a
missing `lgtm` or `approved` label)
Expand Down

0 comments on commit 62cc217

Please sign in to comment.