Remove unnecessary "instanceof" check in ComplexPropertyCollection

zhangyinghahaha · May 30, 2015 · da998b5 · da998b5
1 parent c88387e
commit da998b5
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/.../java/microsoft/exchange/webservices/data/property/complex/ComplexPropertyCollection.java b/.../java/microsoft/exchange/webservices/data/property/complex/ComplexPropertyCollection.java
@@ -103,15 +103,13 @@ protected ComplexPropertyCollection() {
    *
    * @param complexProperty The complex property.
    */
-  protected void itemChanged(ComplexProperty complexProperty) {
-    EwsUtilities
-        .ewsAssert(complexProperty instanceof ComplexProperty, "ComplexPropertyCollection.ItemChanged",
-                   String.format("ComplexPropertyCollection." +
-                                 "ItemChanged: the type of " +
-                                 "the complexProperty argument " +
-                                 "(%s) is not supported.", complexProperty.getClass().getName()));
-
-    TComplexProperty property = (TComplexProperty) complexProperty;
+  protected void itemChanged(final ComplexProperty complexProperty) {
+    final TComplexProperty property = (TComplexProperty) complexProperty;
+    EwsUtilities.ewsAssert(
+      complexProperty != null, "ComplexPropertyCollection.ItemChanged",
+      "The complexProperty argument must be not null"
+    );
+
     if (!this.addedItems.contains(property)) {
       if (!this.modifiedItems.contains(property)) {
         this.modifiedItems.add(property);