REGRESSION: plugins/plugin-remove-readystatechange.html is failing on…

… debug bots https://bugs.webkit.org/show_bug.cgi?id=126169 Reviewed by Antti Koivisto. * plugins/plugin-remove-readystatechange.html: Move the embed so that it's not the last rendered element in the test. It's only a workaround, not a real fix - if anyone is interested in fixing the issue for real, please file a new bug. Also, demystified the test by using readyState instead of counting readystatechange events. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@177879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
zhaodm · Jan 5, 2015 · 2b11558 · 2b11558
1 parent 40573ce
commit 2b11558
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2015-01-04  Alexey Proskuryakov  <[email protected]>
+
+        REGRESSION: plugins/plugin-remove-readystatechange.html is failing on debug bots
+        https://bugs.webkit.org/show_bug.cgi?id=126169
+
+        Reviewed by Antti Koivisto.
+
+        * plugins/plugin-remove-readystatechange.html: Move the embed so that it's not the
+        last rendered element in the test. It's only a workaround, not a real fix - if
+        anyone is interested in fixing the issue for real, please file a new bug.
+        Also, demystified the test by using readyState instead of counting readystatechange
+        events.
+
 2015-01-03  Michael Saboff  <[email protected]>
 
         Crash in operationNewFunction when scrolling on Google+

diff --git a/LayoutTests/plugins/plugin-remove-readystatechange.html b/LayoutTests/plugins/plugin-remove-readystatechange.html
@@ -1,26 +1,27 @@
 <!DOCTYPE html>
 <html>
 <body>
+<!-- FIXME: Don't use Flash, it may not be installed on the machine where this test is run.
+     It is not trivial to switch from Flash to TestNetscapePlugin, because we need to be loading
+     a resource in this test. -->
+<embed id="viewer" src="resources/simple_blank.swf"></embed>
 <div>
 This test passes if it does not trip an assert in debug builds.
 It ensures a readystatechange event can't get dispatched until after a plugin is fully removed.
 </div>
-<embed id="viewer" src="resources/simple_blank.swf"></embed>
 <script>
 if (window.testRunner)
     testRunner.dumpAsText();
 
-var i = 0;
 document.addEventListener('readystatechange', function() {
-    if (i == 1) {
+    if (document.readyState == "complete") {
         try {
             document.body.appendChild(document.getElementById('viewer'));
         }
         catch (e) {
             alert('PASS: element could not be re-appended');
        }
     }
-    i++;
 });
 
 window.addEventListener('DOMContentLoaded', function() {