Skip to content

Commit

Permalink
[unittests] Update PlatformUsesGuardPages test status
Browse files Browse the repository at this point in the history
The test doesn't fail anymore after it was updated to check platforms
with page size > 4096:

402806e
("[cppgc][unittests] Only expect guard pages support on 4k platforms.")

[email protected]

Bug: v8:11587
Change-Id: I6be93e9561b9db0d0f948c5e12fea6a067eb0a76
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2813538
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73857}
  • Loading branch information
thibaudmichaud authored and Commit Bot committed Apr 8, 2021
1 parent e5b4a5e commit b377f67
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/unittests/unittests.status
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
# Test uses fancy signal handling. Needs investigation.
'MemoryAllocationPermissionsTest.DoTest': [SKIP],

# cppgc::internal::kGuardPageSize is smaller than kAppleArmPageSize.
'PageMemoryRegionTest.PlatformUsesGuardPages': [FAIL],

# Time tick resolution appears to be ~42 microseconds. Tests expect 1 us.
'TimeTicks.NowResolution': [FAIL],
'RuntimeCallStatsTest.BasicJavaScript': [SKIP],
Expand Down

0 comments on commit b377f67

Please sign in to comment.