Skip to content

Commit

Permalink
Export 'ko.computed' functions just once, not per-instance
Browse files Browse the repository at this point in the history
  • Loading branch information
SteveSanderson committed Aug 10, 2015
1 parent 1ed396f commit df34187
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/subscribables/dependentObservable.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ ko.computed = ko.dependentObservable = function (evaluatorFunctionOrOptions, eva
ko.utils.extend(dependentObservable, deferEvaluationOverrides);
}

ko.exportProperty(dependentObservable, 'peek', dependentObservable.peek);
ko.exportProperty(dependentObservable, 'dispose', dependentObservable.dispose);
ko.exportProperty(dependentObservable, 'isActive', dependentObservable.isActive);
ko.exportProperty(dependentObservable, 'getDependenciesCount', dependentObservable.getDependenciesCount);

// Add a "disposeWhen" callback that, on each evaluation, disposes if the node was removed without using ko.removeNode.
if (state.disposeWhenNodeIsRemoved) {
// Since this computed is associated with a DOM node, and we don't want to dispose the computed
Expand Down Expand Up @@ -419,6 +414,11 @@ ko.exportSymbol('dependentObservable', ko.dependentObservable);
ko.exportSymbol('computed', ko.dependentObservable); // Make "ko.computed" an alias for "ko.dependentObservable"
ko.exportSymbol('isComputed', ko.isComputed);

ko.exportProperty(ko.dependentObservable['fn'], 'peek', ko.dependentObservable['fn'].peek);
ko.exportProperty(ko.dependentObservable['fn'], 'dispose', ko.dependentObservable['fn'].dispose);
ko.exportProperty(ko.dependentObservable['fn'], 'isActive', ko.dependentObservable['fn'].isActive);
ko.exportProperty(ko.dependentObservable['fn'], 'getDependenciesCount', ko.dependentObservable['fn'].getDependenciesCount);

ko.pureComputed = function (evaluatorFunctionOrOptions, evaluatorFunctionTarget) {
if (typeof evaluatorFunctionOrOptions === 'function') {
return ko.computed(evaluatorFunctionOrOptions, evaluatorFunctionTarget, {'pure':true});
Expand Down

0 comments on commit df34187

Please sign in to comment.