update seqAddValue()

zhengxwen · Jun 25, 2024 · df316e4 · df316e4
1 parent f767a38
commit df316e4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/NEWS b/NEWS
@@ -6,6 +6,12 @@ BUG FIXES
     o `seqMerge()` should internally use "chr_position_ref_alt" to distinguish
       the variants in different files
 
+    o `seqAddValue(, varnm="annotation/filter")` should work with a factor
+      variable
+
+    o `seqAddValue(, varnm="variant.id")` can reset the variant IDs with a
+      different number of the variants
+
 
 CHANGES IN VERSION 1.44.0
 -------------------------

diff --git a/R/AddValue.R b/R/AddValue.R
@@ -51,8 +51,8 @@
     stopifnot(is.vector(val), is.character(val) | is.numeric(val))
     if (anyDuplicated(val))
         stop("'val' should be unique.")
-    if (nvar>0L && length(val)!=nvar)
-        stop("length(val) should be ", nvar, ", but received ", length(val))
+    # if (nvar>0L && length(val)!=nvar)
+    #     stop("length(val) should be ", nvar, ", but received ", length(val))
     if (length(desp))
         warning("'desp' is not used.")
     n <- add.gdsn(gdsfile, "variant.id", val, compress=compress, closezip=TRUE,