PCI: Prevent out of bounds access in numa_node override

63692df ("PCI: Allow numa_node override via sysfs") didn't check that the numa node provided by userspace is valid. Passing a node number too high would attempt to access invalid memory and trigger a kernel panic. Fixes: 63692df ("PCI: Allow numa_node override via sysfs") Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> CC: [email protected] # v3.19+
zhenyw · Oct 7, 2015 · 1266963 · 1266963
1 parent de24c18
commit 1266963
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev,
 	if (ret)
 		return ret;
 
-	if (!node_online(node))
+	if (node >= MAX_NUMNODES || !node_online(node))
 		return -EINVAL;
 
 	add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);