Skip to content

Commit

Permalink
staging: unisys: visorbus: Add err handling for function save_crash_m…
Browse files Browse the repository at this point in the history
…essage

The function save_crash_message returns an error, don't ignore it,
respond appropriately and send it up.

Reported-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: David Binder <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
davidker authored and gregkh committed Jan 3, 2017
1 parent ad2a7d6 commit 300ed61
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/staging/unisys/visorbus/visorchipset.c
Original file line number Diff line number Diff line change
Expand Up @@ -728,8 +728,11 @@ bus_create(struct controlvm_message *inmsg)

POSTCODE_LINUX(BUS_CREATE_ENTRY_PC, 0, bus_no, DIAG_SEVERITY_PRINT);

if (uuid_le_cmp(cmd->create_bus.bus_inst_uuid, spar_siovm_uuid) == 0)
save_crash_message(inmsg, CRASH_BUS);
if (uuid_le_cmp(cmd->create_bus.bus_inst_uuid, spar_siovm_uuid) == 0) {
err = save_crash_message(inmsg, CRASH_BUS);
if (err)
goto err_free_bus_info;
}

if (inmsg->hdr.flags.response_expected == 1) {
pmsg_hdr = kzalloc(sizeof(*pmsg_hdr),
Expand Down

0 comments on commit 300ed61

Please sign in to comment.