Skip to content

Commit

Permalink
iommu/vt-d: Remove unnecassary qi clflushes
Browse files Browse the repository at this point in the history
According to the manual: "Hardware access to ...  invalidation queue ...
are always coherent."

Remove unnecassary clflushes accordingly.

Signed-off-by: Nadav Amit <[email protected]>
Signed-off-by: Joerg Roedel <[email protected]>
  • Loading branch information
anadav authored and joergroedel committed Jul 13, 2016
1 parent ffb2d1e commit 452014d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/iommu/dmar.c
Original file line number Diff line number Diff line change
Expand Up @@ -1167,8 +1167,6 @@ static int qi_check_fault(struct intel_iommu *iommu, int index)
(unsigned long long)qi->desc[index].high);
memcpy(&qi->desc[index], &qi->desc[wait_index],
sizeof(struct qi_desc));
__iommu_flush_cache(iommu, &qi->desc[index],
sizeof(struct qi_desc));
writel(DMA_FSTS_IQE, iommu->reg + DMAR_FSTS_REG);
return -EINVAL;
}
Expand Down Expand Up @@ -1243,9 +1241,6 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu)

hw[wait_index] = wait_desc;

__iommu_flush_cache(iommu, &hw[index], sizeof(struct qi_desc));
__iommu_flush_cache(iommu, &hw[wait_index], sizeof(struct qi_desc));

qi->free_head = (qi->free_head + 2) % QI_LENGTH;
qi->free_cnt -= 2;

Expand Down

0 comments on commit 452014d

Please sign in to comment.