Skip to content

Commit

Permalink
ipmi: Fix the I2C address extraction from SPMI tables
Browse files Browse the repository at this point in the history
Unlike everywhere else in the IPMI specification, the I2C address
specified in the SPMI table is not shifted to the left one bit with
the LSB zero.  Instead it is not shifted with the MSB zero.

Reported-by: Sanjeev <[email protected]>
Signed-off-by: Corey Minyard <[email protected]>
  • Loading branch information
cminyard committed May 17, 2016
1 parent 57a38f1 commit 70f95b7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/ipmi/ipmi_ssif.c
Original file line number Diff line number Diff line change
Expand Up @@ -1870,7 +1870,7 @@ static int try_init_spmi(struct SPMITable *spmi)
return -EIO;
}

myaddr = spmi->addr.address >> 1;
myaddr = spmi->addr.address & 0x7f;

return new_ssif_client(myaddr, NULL, 0, 0, SI_SPMI);
}
Expand Down

0 comments on commit 70f95b7

Please sign in to comment.