Skip to content

Commit

Permalink
dma/ep93xx_dma: fix initialization of M2M control register
Browse files Browse the repository at this point in the history
Setting the flags in case of IDE didn't have any effect since the control
register is overwritten few lines below. So move these to be after the control
register is initialized.

Signed-off-by: Rafal Prylowski <[email protected]>
Signed-off-by: Mika Westerberg <[email protected]>
Acked-by: H Hartley Sweeten <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
Rafal Prylowski authored and Vinod Koul committed Dec 5, 2011
1 parent 02f88be commit b62cfc5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/dma/ep93xx_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,10 +459,6 @@ static int m2m_hw_setup(struct ep93xx_dma_chan *edmac)
* This IDE part is totally untested. Values below are taken
* from the EP93xx Users's Guide and might not be correct.
*/
control |= M2M_CONTROL_NO_HDSK;
control |= M2M_CONTROL_RSS_IDE;
control |= M2M_CONTROL_PW_16;

if (data->direction == DMA_MEM_TO_DEV) {
/* Worst case from the UG */
control = (3 << M2M_CONTROL_PWSC_SHIFT);
Expand All @@ -473,6 +469,10 @@ static int m2m_hw_setup(struct ep93xx_dma_chan *edmac)
control |= M2M_CONTROL_SAH;
control |= M2M_CONTROL_TM_RX;
}

control |= M2M_CONTROL_NO_HDSK;
control |= M2M_CONTROL_RSS_IDE;
control |= M2M_CONTROL_PW_16;
break;

default:
Expand Down

0 comments on commit b62cfc5

Please sign in to comment.