Skip to content

Commit

Permalink
pc-bios/s390-ccw: Increase virtio timeout to 30 seconds
Browse files Browse the repository at this point in the history
The current timeout is set to only three seconds - and considering that
vring_wait_reply() or rather get_second() is not doing any rounding,
the real timeout is likely rather 2 seconds in most cases. When the
host is really badly loaded, it's possible that we hit this timeout by
mistake; it's even more likely if we run the guest in TCG mode instead
of KVM.

So let's increase the timeout to 30 seconds instead to ease this situation
(30 seconds is also the timeout that is used by the Linux SCSI subsystem
for example, so this seems to be a sane value for block IO timeout).

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1549079
Signed-off-by: Thomas Huth <[email protected]>
Message-Id: <[email protected]>
Acked-by: Christian Borntraeger <[email protected]>
[CH: tweaked commit message]
Signed-off-by: Cornelia Huck <[email protected]>
  • Loading branch information
huth authored and cohuck committed Apr 3, 2018
1 parent d9b06db commit 23bf419
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pc-bios/s390-ccw/virtio.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "virtio-scsi.h"
#include "bswap.h"

#define VRING_WAIT_REPLY_TIMEOUT 3
#define VRING_WAIT_REPLY_TIMEOUT 30

static VRing block[VIRTIO_MAX_VQS];
static char ring_area[VIRTIO_RING_SIZE * VIRTIO_MAX_VQS]
Expand Down

0 comments on commit 23bf419

Please sign in to comment.