Skip to content

Commit

Permalink
cputlb: Access MemoryRegion with MemOp
Browse files Browse the repository at this point in the history
The memory_region_dispatch_{read|write} operand "unsigned size" is
being converted into a "MemOp op".

Convert interfaces by using no-op size_memop.

After all interfaces are converted, size_memop will be implemented
and the memory_region_dispatch_{read|write} operand "unsigned size"
will be converted into a "MemOp op".

As size_memop is a no-op, this patch does not change any behaviour.

Signed-off-by: Tony Nguyen <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Message-Id: <c4571c76467ade83660970f7ef9d7292297f1908.1566466906.git.tony.nguyen@bt.com>
Signed-off-by: Richard Henderson <[email protected]>
  • Loading branch information
tnguyen-bt authored and rth7680 committed Sep 3, 2019
1 parent 3d9e7c3 commit 4cbb198
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions accel/tcg/cputlb.c
Original file line number Diff line number Diff line change
@@ -906,8 +906,8 @@ static uint64_t io_readx(CPUArchState *env, CPUIOTLBEntry *iotlbentry,
qemu_mutex_lock_iothread();
locked = true;
}
r = memory_region_dispatch_read(mr, mr_offset,
&val, size, iotlbentry->attrs);
r = memory_region_dispatch_read(mr, mr_offset, &val, size_memop(size),
iotlbentry->attrs);
if (r != MEMTX_OK) {
hwaddr physaddr = mr_offset +
section->offset_within_address_space -
@@ -947,8 +947,8 @@ static void io_writex(CPUArchState *env, CPUIOTLBEntry *iotlbentry,
qemu_mutex_lock_iothread();
locked = true;
}
r = memory_region_dispatch_write(mr, mr_offset,
val, size, iotlbentry->attrs);
r = memory_region_dispatch_write(mr, mr_offset, val, size_memop(size),
iotlbentry->attrs);
if (r != MEMTX_OK) {
hwaddr physaddr = mr_offset +
section->offset_within_address_space -

0 comments on commit 4cbb198

Please sign in to comment.