Skip to content

Commit

Permalink
qom/cpu: Add MemoryRegion property
Browse files Browse the repository at this point in the history
Add a MemoryRegion property, which if set is used to construct
the CPU's initial (default) AddressSpace.

Signed-off-by: Peter Crosthwaite <[email protected]>
[PMM: code is moved from qom/cpu.c to exec.c to avoid having to
 make qom/cpu.o be a non-common object file; code to use the
 MemoryRegion and to default it to system_memory added.]
Signed-off-by: Peter Maydell <[email protected]>
Acked-by: Edgar E. Iglesias <[email protected]>
  • Loading branch information
pete128 authored and pm215 committed Jan 21, 2016
1 parent f0c02d1 commit 6731d86
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cpus.c
Original file line number Diff line number Diff line change
Expand Up @@ -1375,8 +1375,10 @@ void qemu_init_vcpu(CPUState *cpu)
/* If the target cpu hasn't set up any address spaces itself,
* give it the default one.
*/
AddressSpace *as = address_space_init_shareable(cpu->memory,
"cpu-memory");
cpu->num_ases = 1;
cpu_address_space_init(cpu, &address_space_memory, 0);
cpu_address_space_init(cpu, as, 0);
}

if (kvm_enabled()) {
Expand Down
14 changes: 14 additions & 0 deletions exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,20 @@ void cpu_exec_init(CPUState *cpu, Error **errp)

#ifndef CONFIG_USER_ONLY
cpu->thread_id = qemu_get_thread_id();

/* This is a softmmu CPU object, so create a property for it
* so users can wire up its memory. (This can't go in qom/cpu.c
* because that file is compiled only once for both user-mode
* and system builds.) The default if no link is set up is to use
* the system address space.
*/
object_property_add_link(OBJECT(cpu), "memory", TYPE_MEMORY_REGION,
(Object **)&cpu->memory,
qdev_prop_allow_set_link_before_realize,
OBJ_PROP_LINK_UNREF_ON_RELEASE,
&error_abort);
cpu->memory = system_memory;
object_ref(OBJECT(cpu->memory));
#endif

#if defined(CONFIG_USER_ONLY)
Expand Down
1 change: 1 addition & 0 deletions include/qom/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ struct CPUState {
CPUAddressSpace *cpu_ases;
int num_ases;
AddressSpace *as;
MemoryRegion *memory;

void *env_ptr; /* CPUArchState */
struct TranslationBlock *current_tb;
Expand Down

0 comments on commit 6731d86

Please sign in to comment.