9pfs/proxy: Check return value of proxy_marshal()

This should always successfully write exactly two 32-bit integers. Make it clear with an assert(), like v9fs_receive_status() and v9fs_receive_response() already do when unmarshalling the same header. Fixes: Coverity CID 1438968 Reviewed-by: Christian Schoenebeck <[email protected]> Message-Id: <[email protected]> Signed-off-by: Greg Kurz <[email protected]>
zhijianli88 · Jan 21, 2021 · acef3f8 · acef3f8
1 parent fef80ea
commit acef3f8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
@@ -537,7 +537,8 @@ static int v9fs_request(V9fsProxy *proxy, int type, void *response, ...)
     }
 
     /* marshal the header details */
-    proxy_marshal(iovec, 0, "dd", header.type, header.size);
+    retval = proxy_marshal(iovec, 0, "dd", header.type, header.size);
+    assert(retval == 4 * 2);
     header.size += PROXY_HDR_SZ;
 
     retval = qemu_write_full(proxy->sockfd, iovec->iov_base, header.size);