Skip to content

Commit

Permalink
ui: use libexpoxy
Browse files Browse the repository at this point in the history
libepoxy does the opengl extension handling for us.

It also is helpful for trouble-shooting as it prints nice error messages
instead of silently failing or segfaulting in case we do something
wrong, like using gl commands not supported by the current context.

Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
  • Loading branch information
kraxel committed May 29, 2015
1 parent ce0274f commit dcf3002
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -3166,14 +3166,14 @@ else
fi

if test "$opengl" != "no" ; then
opengl_pkgs="gl glesv2"
opengl_pkgs="gl glesv2 epoxy"
if $pkg_config $opengl_pkgs x11 && test "$have_glx" = "yes"; then
opengl_cflags="$($pkg_config --cflags $opengl_pkgs) $x11_cflags"
opengl_libs="$($pkg_config --libs $opengl_pkgs) $x11_libs"
opengl=yes
else
if test "$opengl" = "yes" ; then
feature_not_found "opengl" "Install GL devel (e.g. MESA)"
feature_not_found "opengl" "Please install opengl (mesa) devel pkgs: $opengl_pkgs"
fi
opengl_cflags=""
opengl_libs=""
Expand Down
3 changes: 1 addition & 2 deletions include/ui/console.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
#include "qapi/error.h"

#ifdef CONFIG_OPENGL
# include <GLES2/gl2.h>
# include <GLES2/gl2ext.h>
# include <epoxy/gl.h>
#endif

/* keyboard/mouse support */
Expand Down
5 changes: 1 addition & 4 deletions include/ui/shader.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
#ifdef CONFIG_OPENGL
# include <GLES2/gl2.h>
# include <GLES2/gl2ext.h>
#endif
#include <epoxy/gl.h>

void qemu_gl_run_texture_blit(GLint texture_blit_prog);

Expand Down

0 comments on commit dcf3002

Please sign in to comment.